let blocks are a nonstandard SpiderMonkey feature we would like to remove (in bug 1023609).

Comment on attachment 8564653 [details] [diff] [review] remove-let-blocks.patch Review of attachment 8564653 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/tests/network/head_network.js @@ +13,5 @@ > > // Import common head. > +let commonFile = do_get_file("../head_common.js", false); > +let uri = Services.io.newFileURI(commonFile); > +Services.scriptloader.loadSubScript(uri.spec, this); any reason to not keep this consistent with the other heads (thus in a scope)? ::: toolkit/components/places/tests/unit/test_getPlacesInfo.js @@ +55,5 @@ > add_task(test_getPlacesInfoNonExistentPlace); > > function test_promisedHelper() { > + let uri = NetUtil.newURI("http://www.helper_existent_example.tld"); > + yield PlacesTestUtils.addVisits(uri); while here please decorate this function as a generator @@ +90,5 @@ > > function test_mixed_selection() { > let placeInfo1, placeInfo2; > + let uri = NetUtil.newURI("http://www.mixed_selection_test_1.tld"); > + yield PlacesTestUtils.addVisits(uri); ditto

Thanks! I added back the scope head_network.js and decorated the generator functions. https://hg.mozilla.org/integration/mozilla-inbound/rev/4c7c8d030d08