Closed
Bug 1133753
Opened 10 years ago
Closed 10 years ago
Convert Mozmill about-window.js library to Python/Marionette
Categories
(Testing :: Firefox UI Tests, defect, P1)
Testing
Firefox UI Tests
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla39
People
(Reporter: bsilverberg, Assigned: bsilverberg)
References
Details
Attachments
(1 file, 1 obsolete file)
To support the update tests, we need to convert the following library:
http://hg.mozilla.org/qa/mozmill-tests/file/e16ab8d3d62d/firefox/lib/ui/about-window.js
Updated•10 years ago
|
Priority: -- → P1
Whiteboard: [blocked]
Assignee | ||
Comment 1•10 years ago
|
||
This PR includes the commits for SoftwareUpdate as well, as AboutWindow depends on SoftwareUpdate, so you may want to wait to review this. Alternatively, you could just review the single commit in the PR that includes all the AboutWindow changes.
Attachment #8569973 -
Flags: review?(hskupin)
Comment 2•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
This looks great. The one big thing it misses is the usage of a separate class for the deck, so we have the correct abstraction similar to the pageinfo window.
Attachment #8569973 -
Flags: review?(hskupin) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
This is ready for another review
Attachment #8569973 -
Flags: review?(hskupin)
Comment 4•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
I added my comments to the PR. We still have a bit to do here.
Attachment #8569973 -
Flags: review?(hskupin) → review-
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
This is ready for another review. As discussed today is my last day for a week, so you might need to finish this up for me.
Attachment #8569973 -
Flags: review?(hskupin)
Comment 6•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
r- mostly because of the button elemnet usage which seems to not work because those are not existent. Please check all my comments on the PR.
Attachment #8569973 -
Flags: review?(hskupin) → review-
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
This is ready for another review. As I noted on the diff, the wait_for_download_finished doesn't seem to be working when I test it manually. As I am now disappearing for a week, I assume you will take this over. I hope what I've done thus far is a good start.
Attachment #8569973 -
Flags: review?(hskupin)
Comment 8•10 years ago
|
||
Comment on attachment 8569973 [details]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107
This looks way better! But I have to r- because its still broken due to the usage of `Cu` and `Ci` in prefs.py. I will fix that and some nits in my follow-up PR.
Attachment #8569973 -
Flags: review?(hskupin) → review-
Updated•10 years ago
|
Assignee: nobody → bob.silverberg
Whiteboard: [blocked]
Comment 9•10 years ago
|
||
PR 121 replaces PR 107 from Bob with some additional fixes. Tests via Travis are passing now.
Attachment #8569973 -
Attachment is obsolete: true
Attachment #8574622 -
Flags: review?(cmanchester)
Comment 10•10 years ago
|
||
Comment on attachment 8574622 [details]
github_pull_request.txt
Looks good. Some style comments in github, no blockers though.
Attachment #8574622 -
Flags: review?(cmanchester) → review+
Comment 11•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Updated•9 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•