Boris Zbarsky [:bzbarsky] Assignee
	Description • 10 years ago

Right now, we have a setup for DOM proxies where unforgeable props are stored on a special "unforgeable holder" object that hangs off the proto.

I'm going to remove this and put the props on the object itself (so on the expando object).  This should be fine, because the only proxy we have with unforgeables is HTMLDocument, and it's not like we have tons of those around.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 3 • 10 years ago

Apart from the removal of sharedRoot, the only changes to generated code are in HTMLDocumentBinding.cpp and ImageDocumentBinding.cpp.  This is a diff of the former; the latter is much the same.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 10 years ago

This has those ReleaseWrapper fixes we discussed on IRC.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 7 • 9 years ago

This fixes the problem caught by the second part of the test: named getters can interfere with defineProperty on the proxy, so we really do want to define unforgeables directly on the expando object in the proxy case.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 8 • 9 years ago

OK.  There is in fact still an issue here, not even counting the bits in bug 928336 that might mean we want to hold on to the holder.

In particular, for the non-proxy case we really do want to define unforgeable stuff before we SetWrapper.  Otherwise the unforgeable bits trigger wrapper preservation...

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 9 • 9 years ago

Oh, and for proxies, simply creating the expando object triggers wrapper preservation.  And there's no other obvious place to put it where it won't be slow.

Maybe we just need to have different ordering for the SetWrapper() calls in the proxy and non-proxy cases. I think that should be ok.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 12 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b8c313a2586
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f320d0be370

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 13 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/1b8c313a2586
https://hg.mozilla.org/mozilla-central/rev/6f320d0be370