Closed
Bug 1133781
(perf-tool-crashes)
Opened 10 years ago
Closed 10 years ago
[meta] Many tests crash after ending in the new performance tool
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vporof, Unassigned)
References
Details
(Keywords: meta)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Take a look at this gum run: https://treeherder.mozilla.org/#/jobs?repo=gum&revision=2af669f79b9e Almost all failures are crashes, even though all the checks pass during the test.
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Updated•10 years ago
|
Alias: perf-tool-crashes
Reporter | ||
Updated•10 years ago
|
Blocks: perf-tool-v2, enable-perf-tool
Reporter | ||
Updated•10 years ago
|
No longer blocks: perf-tool-v2
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Comment 2•10 years ago
|
||
Looks like browser_perf-compatibility-04.js is the worst offender, so that could be a good starting point to reproduce/debug this.
Comment 3•10 years ago
|
||
For the new performance developer tools, we're seeing a lot from what we believe is the profiler. Tromey has done some debugging in bug 1133791 (comment #1), and seems to be some sort of JIT error. Do any of you have any idea what could be causing this, possible solutions, next steps? Once these crashes are solved, we'll flip the switch to enable in Nightly for the new profiler/timeline tool. Thanks!
Flags: needinfo?(shu)
Flags: needinfo?(luke)
Flags: needinfo?(jdemooij)
Comment 4•10 years ago
|
||
Forwarding to Kannan as this is probably fallout from the new profiler backend.
Flags: needinfo?(jdemooij) → needinfo?(kvijayan)
Updated•10 years ago
|
Flags: needinfo?(luke)
Reporter | ||
Comment 5•10 years ago
|
||
Attaching the patch I used with djvj to debug this. We ended up concluding that a normally dispatched event on the main thread isn't being executed (via `executeSoon`), because of the beachball, which can mean one of three things: 1. the event is removed from the dispatcher, 2. the dispatcher is blocked waiting for something, 3. the dispatcher itself died. Since the debugger server is making heavy use of those, it's entirely possible that while the clients are shutting down, some packets end up being stuck. We'll be looking more into this on Monday. I hope there's some delirium tremens in our keg.
Comment 6•10 years ago
|
||
Clearing needinfo. Found iloop in _findOptimalTickInterval in devtools/shared/timeline/markers-overview.js
Flags: needinfo?(shu)
Flags: needinfo?(kvijayan)
Reporter | ||
Comment 9•10 years ago
|
||
Paul, these are the current outstanding crashes on gum: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1133781&hide_resolved=1
Flags: needinfo?(paul)
Reporter | ||
Comment 10•10 years ago
|
||
Talked to shu and I'm not panicking anymore. Removing needinfo
Flags: needinfo?(paul)
Reporter | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•