Closed
Bug 1133967
Opened 10 years ago
Closed 10 years ago
[Customizer] View CSS and JS files (no editing)
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cserran, Assigned: djf)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•10 years ago
|
Blocks: spark-p2p-sharing
Reporter | ||
Updated•10 years ago
|
No longer blocks: spark-p2p-sharing
Comment 1•10 years ago
|
||
Amy, Jacqueline, how do you intend to get to this view? I don't see a reasonable path to it with the current design. Maybe an additional option in the long-press menu to "View Source" if the target node is a `<link>` or has a `src` attribute?
Flags: needinfo?(jsavory)
Flags: needinfo?(amlee)
Updated•10 years ago
|
Status: NEW → UNCONFIRMED
Ever confirmed: false
Comment 2•10 years ago
|
||
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #1)
> Amy, Jacqueline, how do you intend to get to this view? I don't see a
> reasonable path to it with the current design. Maybe an additional option in
> the long-press menu to "View Source" if the target node is a `<link>` or has
> a `src` attribute?
That's what I was thinking. In our current long-press action menu, we can add a "View Source" option for <link> and <script> tags.
Comment 3•10 years ago
|
||
(In reply to Justin D'Arcangelo [:justindarc] from comment #2)
> That's what I was thinking. In our current long-press action menu, we can
> add a "View Source" option for <link> and <script> tags.
Seems reasonable to me. Though, IMO, our qualifiers for this additional button should be `<link>` and `<script>` elements or the `src` attribute, so that we could also view images (the code path should be nearly identical).
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 4•10 years ago
|
||
Taking this to see if I can move it forward at all.
Assignee: nobody → dflanagan
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•10 years ago
|
||
Justin,
Here's the PR for view source. Since I'm new to this framework, I don't think I should land it myself without your review.
I don't have write access to the customizer repo so you'll have to land it anyway.
Attachment #8566886 -
Flags: review?(jdarcangelo)
Comment 6•10 years ago
|
||
Comment on attachment 8566886 [details]
link to patch on github
LGTM. Landed. Also, I'll add you to the repo owners group so you can land in the future. Thanks!
Attachment #8566886 -
Flags: review?(jdarcangelo) → review+
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
The design for this has been added in the spec, one of the toolbar icons will represent 'View Source'. Let me know if this works.
Flags: needinfo?(jsavory)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [lightsaber] → [spark]
Updated•7 years ago
|
Flags: needinfo?(amlee)
You need to log in
before you can comment on or make changes to this bug.
Description
•