There's some boilerplate when creating Baseline IC stubs and we usually end up passing the same arguments to a number of different functions. This is especially annoying for stubs that have many fields, like the ones for getters/setters. This patch eliminates the static New* method on each stub and replaces it with a single variadic template function in the ICStub base class. Then instead of FooStub::New(...) we have ICStub::New<FooStub>(...), but otherwise it works exactly the same. This shrinks BaselineIC.h a lot: 2 files changed, 191 insertions(+), 1008 deletions(-) We use similar things elsewhere in the codebase so hopefully this will work with all our compilers, but I kicked off a Try run just to be sure.

Yay, all compilers happily accept it.

Comment on attachment 8565903 [details] [diff] [review] Patch Review of attachment 8565903 [details] [diff] [review]: ----------------------------------------------------------------- Nice! Yay variadic templates and perfect forwarding!

Thanks for the quick review! https://hg.mozilla.org/integration/mozilla-inbound/rev/cda91b1179bf