Closed
Bug 1134149
Opened 9 years ago
Closed 9 years ago
Throw the correct exceptions when setting withCredentials.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: bzbarsky, Mentored)
References
Details
Attachments
(1 file)
See the spec: <https://xhr.spec.whatwg.org/#the-withcredentials-attribute>; the code is at <https://mxr.mozilla.org/mozilla-central/source/dom/base/nsXMLHttpRequest.cpp?rev=20729b28eb1e#3368>. Tests at <http://w3c-test.org/XMLHttpRequest/XMLHttpRequest-withCredentials.html> and <http://w3c-test.org/XMLHttpRequest/XMLHttpRequest-withCredentials.worker>; can also be run with ./mach web-platform-tests --include XMLHttpRequest/XMLHttpRequest-withCredentials.html
Assignee | ||
Comment 1•9 years ago
|
||
You are the lucky reviewer
Attachment #8566047 -
Flags: review?(Ms2ger)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8566047 [details] [diff] [review] Throw the exception the spec calls for when withCredentials is set on a sent XMLHttpRequest object Review of attachment 8566047 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsXMLHttpRequest.cpp @@ +108,5 @@ > #define XML_HTTP_REQUEST_DONE (1 << 4) // 4 DONE > +#define XML_HTTP_REQUEST_SENT (1 << 5) // Internal, corresponds to > + // "OPENED and the send() > + // flag is set" in spec > + // terms.. Two periods?
Attachment #8566047 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Removed the extra period: https://hg.mozilla.org/integration/mozilla-inbound/rev/d942232f7ce6
Flags: in-testsuite+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d942232f7ce6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•