Closed
Bug 1135139
Opened 10 years ago
Closed 10 years ago
Increment the versions in install.rdf when we sign the add-on
Categories
(addons.mozilla.org Graveyard :: Maintenance Scripts, defect)
addons.mozilla.org Graveyard
Maintenance Scripts
Tracking
(Not tracked)
RESOLVED
FIXED
2015-04
People
(Reporter: clouserw, Assigned: magopian)
References
Details
(Whiteboard: [qa-])
This is only for the big "sign add-on" script in bug 1070227. After that initial run newly submitted add-ons should have larger versions anyway. So, for that script we need to increment the actual version value in the install.rdf file in the .zip. Mossop assures me that simply tacking a .1 onto the end of the value will work, no matter what the existing value is, so we shouldn't need to parse it or try to figure out their versioning scheme.
Assignee | ||
Comment 1•10 years ago
|
||
PR: https://github.com/mozilla/olympia/pull/463
Target Milestone: --- → 2015-04
Assignee | ||
Comment 2•10 years ago
|
||
Here's the content of a comment on github (https://github.com/mozilla/olympia/pull/463#discussion_r26173902): """ This isn't going to work. See https://bugzil.la/1070227#c3 For version numbers which already have 4 components, this is going to make the new version number lower than the current version number. This turned out to be a significant issue in last round of SDK repacks. """ Kris also said "We already have code for dealing with toolkit versions in validator.version. I think the easiest thing to do would be to make these objects mutable. I wrote that module, so let me know if you want me to do that." Dave, what do you think?
Flags: needinfo?(dtownsend)
Comment 3•10 years ago
|
||
Bug 1070227 comment 3 contains some incorrect information. It claims that Firefox only recognizes 4-component version numbers. Unless you plan on supporting Firefox 1.0 this is not true. Firefox accepts an unlimited number of version components. Perhaps AMO has a limit on the number of version components?
Flags: needinfo?(dtownsend)
Assignee | ||
Comment 4•10 years ago
|
||
Thanks Dave for the reply, Kris, do you have a clue about that?
Flags: needinfo?(kmaglione+bmo)
Comment 5•10 years ago
|
||
Hm. You're right. I was going off what the toolkit versions MDN page used to say. But I actually ported the version comparator to Python with the correct behavior, so I guess I have no excuse. I think we're good, then.
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 6•10 years ago
|
||
Fixed in https://github.com/mozilla/olympia/commit/78a206e15631d05fc8b531c081163e5ebef30e5c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•