Closed Bug 1135200 Opened 10 years ago Closed 10 years ago

Create nsCSSParser::Startup method, to set up pref-backed static bool variables

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file, 1 obsolete file)

In bug 1107378 comment 2, dbaron asked that I add a nsCSSParser startup method that hooks up a boolean to an about:config pref, rather than doing the "pref / is-pref-cached" dance the first time the code is run. We've got some existing code in nsCSSParser that already does this dance (for "sOpentypeSVGEnabled"), so I'm splitting off this helper-bug to create the startup function to hook up that existing bool to a pref, and then in bug 1107378 I'll address dbaron's review comment by adding a new line to this newly-created startup function. (This way we'll be internally consistent within nsCSSParser, and we can keep this pref-hookup-refactoring logically separate from bug 1107378.) (Note: I'm marking this as "depends-on" bug 1135181 simply because they share some contextual code (in nsLayoutStatics::Initialize), and I'm layering this patch on top of bug 1135181's patch.)
Attached patch fix v1 (obsolete) (deleted) — Splinter Review
Attachment #8567255 - Flags: review?(cam)
Attached patch fix v2 (deleted) — Splinter Review
(Er, of course we need to declare the static bool up at the top of the .cpp file, rather than at the bottom, in order to reference it from code in the middle of the file. Fixed that here.)
Attachment #8567255 - Attachment is obsolete: true
Attachment #8567255 - Flags: review?(cam)
Attachment #8567314 - Flags: review?(cam)
(Gentle review-ping -- this is all that's blocking bug 1107378 from landing, & I'd love to get this & that in before too long, for maximal nightly testing/baking!)
Flags: needinfo?(cam)
Comment on attachment 8567314 [details] [diff] [review] fix v2 Review of attachment 8567314 [details] [diff] [review]: ----------------------------------------------------------------- Sorry, slipped past my gaze; looks good.
Attachment #8567314 - Flags: review?(cam) → review+
Flags: needinfo?(cam)
OS: Linux → All
Hardware: x86_64 → All
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: