Closed
Bug 1135842
Opened 10 years ago
Closed 10 years ago
[Customizer] Figure out and implement a better gesture to open the Customizer
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: drs, Assigned: djf)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Right now, the gesture to open the Customizer is a long press on the element that you want to inspect. We should select a new gesture and use that instead.
Generally speaking, none of these will work:
1. A series of single taps, because the user is forced to interact with content when making the gesture.
2. Long presses, for the same reason as 1.
3. Edge gestures, because the System app watches for them.
Here are a few ideas I had:
a. Three-finger pinch to zoom in either direction.
b. One finger down for ~0.2-0.4s on the target element, then another down, with both held, for 1s.
c. A circle around the element, then a tap.
Note that this will have no impact on the gesture used to select elements once the Customizer is open. I think that we're all in agreement that single taps are acceptable here, as long as the user is allowed to interact at the same time.
Reporter | ||
Comment 1•10 years ago
|
||
Amy, Patryk, Jacqueline, any thoughts here?
Flags: needinfo?(padamczyk)
Flags: needinfo?(jsavory)
Flags: needinfo?(amlee)
Comment 2•10 years ago
|
||
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #1)
> Amy, Patryk, Jacqueline, any thoughts here?
I believe Jacqueline is working on a customizer spec that will address this. I'll let her chime in.
Flags: needinfo?(amlee)
Comment 3•10 years ago
|
||
Doug, I thought for a. we only support 2 finger touch gestures.
We probably don't want to do #2 since long presses are used in other apps.
I still don't understand why we can do #1. Have you tried "Hyperlapse" it was really works well... 4 finger tap. We can do a 2 finger tap a few times, keep it simple.
Flags: needinfo?(padamczyk)
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Patryk Adamczyk [:patryk] UX from comment #3)
> Doug, I thought for a. we only support 2 finger touch gestures.
Previously, this was a hardware limitation of the devices that we were targeting. I think that the Aries device will support more active touches than that, but I don't know.
> I still don't understand why we can do #1.
Why we _can't_ do it? If the user is tapping on a button, or any interactive content, it forces them to take that action. For example, if the user wants to inspect a "Settings" button, they would have to tap it, thus opening the "Settings" view, and they can no longer inspect the button because it's out of view.
> Have you tried "Hyperlapse" it was really works well... 4 finger tap.
That could work, but it would be difficult to target a specific element with that.
> We can do a 2 finger tap a few times, keep it simple.
I don't think that this will work, for similar reasons to #1. The 4-finger tap works because we can watch for all 4 touches before any "click" events are dispatched.
Reporter | ||
Updated•10 years ago
|
Blocks: spark-customizer
Comment 5•10 years ago
|
||
Assigning to David to work on once a decision on the gesture has been made.
Assignee: nobody → dflanagan
Reporter | ||
Comment 6•10 years ago
|
||
Justin, David, Kevin, and I all chatted on IRC about this. We'd still like UX input, but we agreed that the best thing to do here for now is use a 2-finger drag-from-bottom edge gesture to open the Customizer, and then let the user tap on the element that they want to select. The pros of this gesture are:
1. It is simple and easy for the user to perform.
2. It doesn't really conflict with anything important, and is difficult to do accidentally.
3. It allows us to flow naturally into resizing the Customizer window, should we so desire to let the user do that.
The only issue with this is that it conflicts with the software home/task manager gesture. However, we may be able to kill this gesture as it no longer seems necessary.
Blocks: 1138698
Assignee | ||
Comment 7•10 years ago
|
||
We'll also need a gesture to dismiss the customizer. I actually like the idea of making a circle around the element of interest, but that does not lead to any intuitive way to dismiss. So a two finger swipe up from the bottom edge to bring the customizer up, and a two finger swipe down to dismiss sounds like the way to go here.
Assignee | ||
Comment 8•10 years ago
|
||
Justin,
Would you try this out and make sure it works for you? A two finger swipe up from the bottom of the screen should open the panel and a two finger swipe down from the middle of the screen should close it. I want to make sure I didn't mess up the bower.json file or the custombuild file.
You can review the fxos/gesture code too, if you've got time, but that doesn't seem critical at this stage.
If this looks okay to you, feel free to merge. I won't be back online until after noon your time.
Attachment #8572482 -
Flags: review?(jdarcangelo)
Reporter | ||
Comment 9•10 years ago
|
||
https://github.com/fxos/customizer/commit/ccd3394232fda4ab44e9eabe38b87b6c8653af07
There will be some followup work here.
1. The System app is capturing events that begin at the bottom of the screen, so maybe we need to select a new gesture.
2. We had to opt for 1 finger swiping to open/close the Customizer due to bug 1139575.
3. We should, at the very least, add a nice open/close animation.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
Comment on attachment 8572482 [details]
patch to add a two finger swipe gesture to open and close
Clearing r? since this already landed.
Attachment #8572482 -
Flags: review?(jdarcangelo)
Updated•10 years ago
|
Whiteboard: [lightsaber] → [ignite]
Updated•10 years ago
|
Whiteboard: [ignite] → [spark]
You need to log in
before you can comment on or make changes to this bug.
Description
•