Closed Bug 1135854 Opened 10 years ago Closed 10 years ago

[Customizer] Make the "Settings" button take as little space as possible

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: drs)

References

Details

(Whiteboard: [spark]) 

The "Settings" button is encapsulated in a <gaia-header> element, which takes the entire horizontal space of the region that it occupies. This is much more than is needed, and the only advantage of using this element is the positioning that we get for free, incl. RTL support. To fix this, we can make it a single |<div><a></a></div>| block that we position manually.
Blocks: spark-customizer
No longer blocks: 1133835
Assignee: nobody → drs.bugzilla
Status: NEW → ASSIGNED
Priority: -- → P1
https://github.com/fxos/customizer/commit/63a010b35b9cf6d86e039959651eb3b03c582dc6

I also landed some changes to MutationObserver here.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.