Closed Bug 1136177 Opened 9 years ago Closed 9 years ago

Amount by mouse wheel scrolling is wrong

Categories

(Core :: Widget: Win32, defect)

39 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla39
Tracking Status
firefox38 --- unaffected
firefox39 - verified

People

(Reporter: alice0775, Assigned: jacek)

References

Details

(Keywords: regression)

Attachments

(1 file)

Steps To Reproduce:
1. Open long web page (ex. http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/ )
2. Scroll with Mouse Wheel

Actual Results:
Page was scrolled by a page

Expected results:
Page should be scrolled by few lines

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=50752f206a9b&tochange=0adcaee7f3bb

Regressed by: Bug 1133818
Flags: needinfo?(jacek)
WinMouseScrollHandler.h change probably broke it. I will prepare a fix.
Assignee: nobody → jacek
Flags: needinfo?(jacek)
(In reply to Jacek Caban from comment #1)
> WinMouseScrollHandler.h change probably broke it. I will prepare a fix.

yep, just confirmed, flipping those two vars back to signed fixes the problem.
Attached patch fix (deleted) — Splinter Review
The fix is attached. I'm sorry for breaking this and thank you for the report.
Attachment #8568616 - Flags: review?(jmathies)
Attachment #8568616 - Flags: review?(jmathies) → review+
Will land this as soon as inbound opens.
Flags: in-testsuite?
https://hg.mozilla.org/integration/mozilla-inbound/rev/bab13c0c9e19

Please try to use more descriptive commit messages in the future (i.e. what the patch is actually doing instead of restating the problem it's solving).
https://hg.mozilla.org/mozilla-central/rev/bab13c0c9e19
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Will this be included in tomorrow's nightly?
(In reply to Bartosz Piec from comment #16)
Yes.
Please reopen the bug, I am facing the problem again
https://bugzilla.mozilla.org/show_bug.cgi?id=1136547
(In reply to Sohan Roy from comment #18)
> Please reopen the bug, I am facing the problem again

Nightly hasn't updated yet.
(In reply to Sohan Roy from comment #18)
Nightly updated now and it is fixed. :)
yep, I can confirm the fix as well.
Status: RESOLVED → VERIFIED
I don't think we need to track this for 39 since it's so early in the cycle and is already fixed and verified. That was fast, thanks!

We certainly had a lot of users notice and report it, so if it happens again, we're likely to hear about it.
i too had this prob, its fixed after another update
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: