Closed
Bug 1136292
Opened 10 years ago
Closed 10 years ago
Stop passing explicit "JS::NullPtr()" or "global" args to JS_NewObjectWithGivenProto
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(5 files)
|
part 1. Stop passing a parent to BindingJSObjectCreator methods, since it's always the global anyway
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
The three-arg form defaults to using the global as proto, and it'd be nice to just get rid of the four-arg form....
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8568716 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8568717 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8568718 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8568719 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8568721 -
Flags: review?(peterv)
|
||
Updated•10 years ago
|
Attachment #8568716 -
Flags: review?(peterv) → review+
|
|
||
Updated•10 years ago
|
Attachment #8568717 -
Flags: review?(peterv) → review+
|
|
||
Updated•10 years ago
|
Attachment #8568718 -
Flags: review?(peterv) → review+
|
|
||
Updated•10 years ago
|
Attachment #8568719 -
Flags: review?(peterv) → review+
|
|
||
Updated•10 years ago
|
Attachment #8568721 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/827eadf15cf0
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d3b11d8765
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fe99535f2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9549bacf53c
https://hg.mozilla.org/integration/mozilla-inbound/rev/06227342cd2e
https://hg.mozilla.org/mozilla-central/rev/827eadf15cf0
https://hg.mozilla.org/mozilla-central/rev/c7d3b11d8765
https://hg.mozilla.org/mozilla-central/rev/13fe99535f2b
https://hg.mozilla.org/mozilla-central/rev/e9549bacf53c
https://hg.mozilla.org/mozilla-central/rev/06227342cd2e
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•