Closed
Bug 1136359
Opened 10 years ago
Closed 10 years ago
Backout Array.includes and String.includes usage in tab completion code
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird37 unaffected, thunderbird38 fixed)
RESOLVED
FIXED
Thunderbird 39.0
Tracking | Status | |
---|---|---|
thunderbird37 | --- | unaffected |
thunderbird38 | --- | fixed |
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
clokep
:
review+
rkent
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Bug 1134905 contained https://hg.mozilla.org/comm-central/rev/56cf0d1ed0a0, which switched to using Array.includes and String.includes. Both of these are however only enabled in nightlies at present, so we need to back it out from both TB and IB.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8568776 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
status-thunderbird38:
--- → affected
tracking-thunderbird38:
--- → ?
tracking-thunderbird_esr38:
--- → ?
Comment 2•10 years ago
|
||
Comment on attachment 8568776 [details] [diff] [review]
noindexof-backout.diff
Review of attachment 8568776 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for asking you to change it!
::: im/content/conversation.xml
@@ -1051,5 @@
> // Keep only the completions that share |word| as a prefix.
> // Be case insensitive only if |word| is entirely lower case.
> let condition;
> if (word.toLocaleLowerCase() == word)
> - condition = c => c.toLocaleLowerCase().startsWith(word);
startsWith landed a few versions ago, I believe.
Attachment #8568776 -
Flags: review?(clokep) → review-
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #2)
> Comment on attachment 8568776 [details] [diff] [review]
> noindexof-backout.diff
>
> Review of attachment 8568776 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Sorry for asking you to change it!
> startsWith landed a few versions ago, I believe.
That's true, but it's cleaner to back out the whole patch imho.
Assignee | ||
Comment 4•10 years ago
|
||
You can pry my startsWith from my cold, dead hands, etc.
Attachment #8568776 -
Attachment is obsolete: true
Attachment #8569417 -
Flags: review?(clokep)
Comment 5•10 years ago
|
||
Comment on attachment 8569417 [details] [diff] [review]
noindexof-backout.diff 2
Thanks! :)
Attachment #8569417 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 38.0
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8569417 [details] [diff] [review]
noindexof-backout.diff 2
[Approval Request Comment]
Regression caused by (bug #): Bug 1134905
User impact if declined: tab completion failures
Risk to taking this patch (and alternatives if risky): none, this is a backout.
Attachment #8569417 -
Flags: approval-comm-aurora?
Assignee | ||
Updated•10 years ago
|
Target Milestone: Thunderbird 38.0 → Thunderbird 39.0
Comment 8•10 years ago
|
||
Comment on attachment 8569417 [details] [diff] [review]
noindexof-backout.diff 2
https://hg.mozilla.org/releases/comm-aurora/rev/4880a53c711b
Attachment #8569417 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Updated•10 years ago
|
status-thunderbird37:
--- → unaffected
tracking-thunderbird_esr38:
? → ---
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Kent James (:rkent) from comment #8)
> https://hg.mozilla.org/releases/comm-aurora/rev/4880a53c711b
Thanks!
Updated•10 years ago
|
tracking-thunderbird38:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•