Tracking changes discussed here: https://github.com/slightlyoff/ServiceWorker/issues/609

Comment on attachment 8568871 [details] [diff] [review] ServiceWorker: client.postMessage should land in navigator.serviceWorker.onmessage. Review of attachment 8568871 [details] [diff] [review]: ----------------------------------------------------------------- Baku for webidl signoff. r=me

Comment on attachment 8568871 [details] [diff] [review] ServiceWorker: client.postMessage should land in navigator.serviceWorker.onmessage. Review of attachment 8568871 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/ServiceWorkerClient.cpp @@ +86,5 @@ > > + ErrorResult result; > + dom::Navigator* navigator = window->GetNavigator(result); > + if (NS_WARN_IF(result.Failed())) { > + return NS_ERROR_FAILURE; return result.ErrorCode(); @@ +91,5 @@ > + } > + > + nsRefPtr<ServiceWorkerContainer> container = navigator->ServiceWorker(); > + if (result.Failed()) { > + NS_WARNING("Failed to dispatch controllerchange event"); really? I don't think we need this if(). the result has been already checked.

Comment on attachment 8569330 [details] [diff] [review] ServiceWorker: client.postMessage should land in navigator.serviceWorker.onmessage. https://hg.mozilla.org/integration/mozilla-inbound/rev/720b1b0c423d