Closed
Bug 1136471
Opened 10 years ago
Closed 10 years ago
remove nsIIdentityInfo.getValidEVPolicyOid
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: keeler, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
nsIIdentityInfo.getValidEVPolicyOid doesn't seem to be used:
https://dxr.mozilla.org/mozilla-central/search?q=getValidEVPolicyOid&case=false
(Also, nothing came up in mxr for addons.)
|
Assignee | |
Comment 1•10 years ago
|
||
I ran |hg grep etValidEVPolicyOid| at the root of m-i for what seemed like an hour or more with nothing interesting popping up, so removing this seems fine to me as well.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Try looks OK so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd51981d38cb
Attachment #8570110 -
Flags: review?(dkeeler)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8570110 [details] [diff] [review]
bug1136471_rm-nsIIdentityInfo.getValidEVPolicyOid()_v1.patch
Review of attachment 8570110 [details] [diff] [review]:
-----------------------------------------------------------------
Great! r=me.
Attachment #8570110 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks for the review.
(Try link is in Comment 2)
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•