Closed
Bug 1136520
Opened 10 years ago
Closed 10 years ago
Stop parenting Xray expando objects to a non-global
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
I don't see an obvious reason for this to be happening; we never seem to get the expando object's parent.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8568932 -
Flags: review?(bobbyholley)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8568932 [details] [diff] [review]
Stop parenting Xray expando objects to a non-global
Review of attachment 8568932 [details] [diff] [review]:
-----------------------------------------------------------------
I think this may have been used before we switched xray expandos to a C++ WeakMap, but now it does indeed appear unused. Huzzah!
::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +941,5 @@
> JS_ClearPendingException(cx);
> }
> #endif
>
> // Create the expando object. We parent it directly to the target object.
Comment needs updating.
Attachment #8568932 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment updated, good catch.
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•