I'd like to provide an easy way to toggle ril debugging log from developer menu. 1. In gecko, most of the ril components use preference "ril.debugging.enabled" as the switch to toggle the logging. 2. In bug 1132863, we bind settings key "ril.debugging.enabled" to preference. Therefore, we could simply add a menu option to toggle the settings and the ril logging will be enabled/disabled accordingly.

Comment on attachment 8569021 [details] [gaia] aknow:ril_debug > mozilla-b2g:master Arthur, May I have your review? Also, this is my first time working on gaia. Please guide me how to land the gaia patch if I did something wrong. Thank you.

Comment on attachment 8569021 [details] [gaia] aknow:ril_debug > mozilla-b2g:master The patch looks good, thanks!

Please add "r=arthurcc" in the end of the title on github. Add "checkin-needed" keyword to this bug and then the patch will be merged automatically.

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/760b05d05738ac42cddaa1c595563ae014df321c

Hi aknow, Could you also request uplift to 2.2, it will be very convenient for us, thank you.

Comment on attachment 8569021 [details] [gaia] aknow:ril_debug > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): None [User impact] if declined: None [Testing completed]: None [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: None I know that at this moment, only blocking-b2g:2.2+ or feature-b2g: 2.2+ bugs could be granted to land on the tree. However, I just want to know whether this is worth considering according to previous comment. The patch here along with Bug 1137048 provide a way to toggle ril debugging log from developer menu. More specificly, - This patch: add an option in developer menu. - Bug 1137048: bind settings "ril.debugging.enabled" to preference "ril.debugging.enabled" The risk is pretty low and it could benefit QA for testing work.

(In reply to Szu-Yu Chen [:aknow] from comment #8) > Comment on attachment 8569021 [details] > [gaia] aknow:ril_debug > mozilla-b2g:master > > [Approval Request Comment] > [Bug caused by] (feature/regressing bug #): None > [User impact] if declined: None > [Testing completed]: None > [Risk to taking this patch] (and alternatives if risky): Low > [String changes made]: None > > I know that at this moment, only blocking-b2g:2.2+ or feature-b2g: 2.2+ bugs > could be granted to land on the tree. However, I just want to know whether > this is worth considering according to previous comment. > > The patch here along with Bug 1137048 provide a way to toggle ril debugging > log from developer menu. More specificly, > - This patch: add an option in developer menu. > - Bug 1137048: bind settings "ril.debugging.enabled" to preference > "ril.debugging.enabled" > The risk is pretty low and it could benefit QA for testing work. definitely worth the uplift given the advantage and low risk, so approving this.

v2.2: https://github.com/mozilla-b2g/gaia/commit/c84ab4252faf0b6df87bf78f01ee8394edf170d9

Please remember to add the late-l10n keyword when you land patches on 2.2 with string changes! (too late now) late-l10n keyword use started at FL...thanks!

Hi Aknow, the patch added a new string so we need a late-l10n keyword per comment 11.