We should have a way to recovery when an unknown device connected to TCP presentation server. A possible way is talk to its listener to discovery again and report whether the connecter is in the discovery results.

Controlling device might not register itself as a mDNS device so we need to create a correspond Presentation Device on receiver side while connected.

Here is the summary of this patch: 1) move nsIPresentationDevice generation and storage from TCPPresentationServer to MDNSDeviceProvider 2) move session request event interface from nsIPresentationDeviceEventListener to nsIPresentationDeviceListener 3) TCP control channel now report incoming session request from TCPPresentationServer -> MDNSDeviceProvider -> PresentationDeviceManager 4) establishing control channel now goes from MDNSDevice -> MDNSDeviceProvider -> TCPPresentationServer

Comment on attachment 8674137 [details] [diff] [review] bug1136565-allow-request-from-unknown-controller.patch Review of attachment 8674137 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/presentation/provider/MulticastDNSDeviceProvider.cpp @@ +856,5 @@ > + nsAutoCString id; > + unused << aDeviceInfo->GetId(id); > + uint16_t port; > + unused << aDeviceInfo->GetPort(&port); > + remove trailing spaces @@ +859,5 @@ > + unused << aDeviceInfo->GetPort(&port); > + > + device = new Device(id, id, EmptyCString(), host, port, DeviceState::eActive, nullptr); > + } > + remove trailing space ::: dom/presentation/provider/MulticastDNSDeviceProvider.h @@ +76,4 @@ > { > } > > + const nsCString& Id() const remove trailing space @@ +145,5 @@ > + nsresult RequestSession(Device* aDevice, > + const nsAString& aUrl, > + const nsAString& aPresentationId, > + nsIPresentationControlChannel** aRetVal); > + remove trailing spaces

Comment on attachment 8674137 [details] [diff] [review] bug1136565-allow-request-from-unknown-controller.patch Review of attachment 8674137 [details] [diff] [review]: ----------------------------------------------------------------- lgtm

Update with test cases fixed. Will have minor modification in test case later but we can start the first review.

update with test case modification. @seanlin, mochitest for Presentation API is modified because receiver side session creation event is moved from nsIPresentationDeviceEventListener to nsIPresentationDeviceListener.

Comment on attachment 8675273 [details] [diff] [review] bug1136565.patch Review of attachment 8675273 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/presentation/tests/mochitest/PresentationSessionChromeScript.js @@ +360,5 @@ > addMessageListener('trigger-incoming-session-request', function(url) { > + var deviceManager = Cc['@mozilla.org/presentation-device/manager;1'] > + .getService(Ci.nsIPresentationDeviceManager); > + deviceManager.QueryInterface(Ci.nsIPresentationDeviceListener) > + .onSessionRequest(mockedDevice, url, sessionId, mockedControlChannel); nit: function |simulateSessionRequest| (and possibly the listener setter/getter) of |mockedDevice| may also be removed.

update according to @seanlin's comment and rebase according to RefPtr modification.

Comment on attachment 8675494 [details] [diff] [review] bug1136565-allow-request-from-unknown-controller.patch - v3 Review of attachment 8675494 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/presentation/provider/MulticastDNSDeviceProvider.cpp @@ +277,5 @@ > MulticastDNSDeviceProvider::UnregisterService(nsresult aReason) > { > MOZ_ASSERT(NS_IsMainThread()); > > + ClearDevices(); Per our discussion, devices should not be cleared in unregistration.

Thanks for catching this. Patch is updated according to @xeonchen's comment.

Originally device list is maintained in TCPPresentationServer. We need to clean all device related information and rebuild it while restarting server. (That's the reason why ClearDevice() is invoked in |OnClose|, see comment #11.) We don't need to rescan while restarting server because the device list is maintained in MDNSDeviceProvider directly.