Closed Bug 1136873 Opened 10 years ago Closed 10 years ago

Use MediaPromises for metadata decoding and fix up threading model

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

I've always suspected this code was racey, and bug 1133064 confirms it. Once we land bug 1135170 and bug 1135785, we'll be in a better place to tackle this.
Blocks: 1145203
Assignee: nobody → bobbyholley
Blocks: 1145686
Attachment #8581233 - Flags: review?(matt.woodrow)
The previous setup is wacky, and can cause the notification to reach the state machine before the promise rejection, which causes us to stall intermittently. We also take the opportunity to be a bit less trigger happy when we fire it in MediaSourceReader.cpp.
Attachment #8581234 - Flags: review?(matt.woodrow)
Blocks: 1146086
Attachment #8581234 - Flags: review?(matt.woodrow) → review+
Attachment #8581233 - Flags: review?(matt.woodrow) → review+
Blocks: MediaMonitor
Blocks: 1146485
This collided pretty hard with edwin's work in bug 1134434, so I had to rebase it and run it through try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fea92dd2b6fc https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6b51350e864 I've filed bug 1146485 to get this stuff fixed up nicer.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: