We currently only trigger "saved-session", we also need to store a (subsession) main ping with reason "shutdown". Note: We only want do this on desktop for now.

This patch saves a session ping with the reason "shutdown" when Firefox shuts down, only on Desktop. Adjusts the test_TelemetrySession.js accordingly.

Improved test coverage.

Comment on attachment 8569838 [details] [diff] [review] bug1137139.patch - v2 Review of attachment 8569838 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/TelemetrySession.jsm @@ +1248,3 @@ > }; > + > + let savePending = () => TelemetryPing.savePendingPings(getPingType(savedSessionPayload), make savePending a method in the Impl object and call it saveClassicPing or something similar @@ +1249,5 @@ > + > + let savePending = () => TelemetryPing.savePendingPings(getPingType(savedSessionPayload), > + savedSessionPayload, options); > +#ifndef MOZ_WIDGET_ANDROID > + let shutdownPayload = this.getSessionPayload(REASON_SHUTDOWN, false); is there a reason for clearSubsession = false here?

I assumed we didn't need a new subsession when shutting down, as we are creating a new one when starting Firefox again (and the "saved-session" ping isn't clearing the subsession either). Should I create a new subsession for saving the "shutdown" ping?

This patch adds a |savePendingPingsClassic| function. As discussed over IRC, subsessions should not be created when saving shutdown pings. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=58341471c0d9