+++ This bug was initially created as a clone of Bug #1136729 +++ 2:31.29 In file included from /home/alex/codaz/Mozilla/b2g/gecko/obj-libril-mulet/dom/icc/Unified_cpp_dom_icc0.cpp:11:0: 2:31.29 /home/alex/codaz/Mozilla/b2g/gecko/dom/icc/Icc.cpp: In member function ‘virtual MozExternalRefCountType mozilla::dom::Icc::AddRef()’: 2:31.29 /home/alex/codaz/Mozilla/b2g/gecko/dom/icc/Icc.cpp:50:45: error: static assertion failed: Reference-counted class Icc should not have a public destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerousPublicDestructor specialization for it. 2:31.29 NS_IMPL_ADDREF_INHERITED(Icc, DOMEventTargetHelper)

Comment on attachment 8570455 [details] [diff] [review] [01] Bug 1137155: Marked destructor of |ICC| as protected Review of attachment 8570455 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch, Thomas. r=me with comment addressed. ::: dom/icc/Icc.h @@ +109,5 @@ > IMPL_EVENT_HANDLER(cardstatechange) > IMPL_EVENT_HANDLER(stkcommand) > IMPL_EVENT_HANDLER(stksessionend) > > +protected: Since Icc is defined as MOZ_FINAL, it doesn’t make much sense to have "protected" destructor here. Let's use private instead.

Changes since v1: - marked destructor as private

Thanks, Hsin-Yi! https://hg.mozilla.org/integration/b2g-inbound/rev/a122fad0351c https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=a122fad0351c