+++ This bug was initially created as a clone of Bug #1090742 +++ This bug covers the upstream (webrtc.org) basic portions of vp9 support; it also doesn't cover things about *when* VP9 should be preferred or switched to/from (which may require allowing accepting multiple codecs, which we don't do yet) Note that webrtc branch 40 has vp9 codec support, but it's incomplete and does not include any packetization, and many codepaths don't account for vp9 as a possibility.

Comment on attachment 8570712 [details] [diff] [review] Basic vp9 support added to upstream (using 'generic' packetization) Note: this is known-to-be incomplete, as upstream isn't ready (no VP9 packetization, etc), and I may well back this out before applying the next pull from upstream, then see what they missed (assuming they get to this before the next time we pull).

Comment on attachment 8570712 [details] [diff] [review] Basic vp9 support added to upstream (using 'generic' packetization) Review of attachment 8570712 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Left some minor questions. ::: media/webrtc/trunk/webrtc/modules/video_coding/main/source/video_sender.cc @@ +136,5 @@ > << sendCodec->plName << ". Error code: " << ret; > return VCM_CODEC_ERROR; > } > > + // XXX fix VP9 Is there a bug tracking this fix? ::: media/webrtc/trunk/webrtc/video_engine/vie_codec_impl.cc @@ +87,5 @@ > << codec.codecSpecific.H264.spsLen > << ", ppslen: " > << codec.codecSpecific.H264.ppsLen; > + } else if (codec.codecType == kVideoCodecVP9) { > + LOG(LS_INFO) << "VP9 specific settings"; I think it would be helpful to have some basic information here, as with the VP8 codec above. ::: media/webrtc/trunk/webrtc/video_engine/vie_encoder.cc @@ +635,5 @@ > &codec_specific_info); > return; > } > #endif > + // XXX fix VP9 Is there a bug for this fix?

> ::: media/webrtc/trunk/webrtc/video_engine/vie_codec_impl.cc > @@ +87,5 @@ > > << codec.codecSpecific.H264.spsLen > > << ", ppslen: " > > << codec.codecSpecific.H264.ppsLen; > > + } else if (codec.codecType == kVideoCodecVP9) { > > + LOG(LS_INFO) << "VP9 specific settings"; > > I think it would be helpful to have some basic information here, as with the > VP8 codec above. None of that info is filled in currently, given the lack of packetization data. It's largely a placeholder

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6cd84214a5 https://hg.mozilla.org/integration/mozilla-inbound/rev/29c8632b348e

https://hg.mozilla.org/mozilla-central/rev/bf6cd84214a5 https://hg.mozilla.org/mozilla-central/rev/29c8632b348e