Closed
Bug 1137492
Opened 10 years ago
Closed 10 years ago
cleanup obsolete "for each" loops in /mail/base/content/gloda*
Categories
(Thunderbird :: Search, defect)
Thunderbird
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 39.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
When using the gloda faceted search, there is a ton of JS strict warnings about deprecated constructs, like this:
Warning: JavaScript 1.6's for-each-in loops are deprecated; consider using ES6 for-of instead
Source File: chrome://messenger/content/glodaFacetView.js
Line: 103, Column: 8
Source Code:
for each (let [, groupValue] in Iterator(aGroupValues))
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #8570182 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8570182 [details] [diff] [review]
patch
Review of attachment 8570182 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, r=mkmelin
Attachment #8570182 -
Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
Summary: cleanup obsolete for each loops in /mail/base/content/gloda* → cleanup obsolete "for each" loops in /mail/base/content/gloda*
|
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
You need to log in
before you can comment on or make changes to this bug.
Description
•