Closed Bug 1137571 Opened 10 years ago Closed 10 years ago

Can't slide-and-release press on device (i.e., cancel press) in share overlay

Categories

(Firefox for Android Graveyard :: Overlays, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1122302

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

(Keywords: polish)

0) With sync enabled and 1-3 devices synced 1) Share -> "Add to Firefox" 2) Long press on a device 3) Slide your finger away to cancel press Expected: Press is cancelled Actual: Not cancelled. :( The other menu items cancel; I'm not sure about "Send to other devices".
"Send to other devices" is also broken.
Summary: Can't release press on device in share overlay → Can't release press on device (i.e. cancel press) in share overlay
Mentor: michael.l.comella
Component: General → Overlays
Keywords: polish
Summary: Can't release press on device (i.e. cancel press) in share overlay → Can't slide-and-release press on device (i.e., cancel press) in share overlay
Well, the offending listeners live here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/ui/SendTabDeviceListArrayAdapter.java#116 The different behaviour is presumably because the other buttons are Buttons, and this is some evil magic I cooked up with a list view. Apparently OnClickListeners on TextViews exhibit this undesirable behaviour, but not elsewhere...? I think someone is going to be saying "Oh, Android" before this problem is solved. Is there sone trick Android makes you do to make it not be stupid in this way, or does it normally just work?
Actually, it seems this is the issue [1]: 168 * Prevent scrolling of this ListView. 169 */ 170 @Override 171 public boolean dispatchTouchEvent(MotionEvent ev) { 172 if (ev.getAction() == MotionEvent.ACTION_MOVE) { 173 return true; 174 } 175 176 return super.dispatchTouchEvent(ev); 177 } Handled in bug 1122302 because reviewboard doesn't let you push one commit at the moment and this is good to uplift anyway. [1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/overlays/ui/SendTabList.java?rev=be451dd958bf#168
Assignee: nobody → michael.l.comella
Mentor: michael.l.comella
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.