Closed
Bug 1138240
Opened 10 years ago
Closed 10 years ago
[EME] Handle CDMs resolving promises more than once
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The Adobe CDM is resolving promises more than once. We're not handling this properly (we assert in debug builds at least) which is causing the Adobe Demo page to fail.
|
Assignee | |
Comment 1•10 years ago
|
||
Add more logging around promises, and ensure we ignore the CDM trying to resolve an already resolved promise.
Attachment #8571105 -
Flags: review?(edwin)
Comment on attachment 8571105 [details] [diff] [review]
Patch: Ignore a CDM trying to resolve an already resolved promise
Review of attachment 8571105 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/media/eme/MediaKeys.cpp
@@ +188,5 @@
> MediaKeys::RetrievePromise(PromiseId aId)
> {
> + if (!mPromises.Contains(aId)) {
> + NS_WARNING("Tried to retrieve a non-existent promise");
> + return nullptr;
It could be useful to log the promise ID even if it's a dupe.
Attachment #8571105 -
Flags: review?(edwin) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(cpearce)
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
|
Assignee | |
Comment 5•10 years ago
|
||
status-firefox37:
--- → fixed
|
|
Assignee | |
Comment 6•10 years ago
|
||
Patch for beta branch as part of EME platform uplift.
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8572389 [details] [diff] [review]
Beta patch
Requesting (retroactive for beta) approval for Beta and Aurora landing as part of EME platform uplift.
Flags: needinfo?(cpearce)
Attachment #8572389 -
Flags: approval-mozilla-beta?
Attachment #8572389 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Updated•10 years ago
|
status-firefox38:
--- → affected
|
|
Assignee | |
Comment 8•10 years ago
|
||
|
||
Comment 9•10 years ago
|
||
Comment on attachment 8572389 [details] [diff] [review]
Beta patch
Approved for Beta and Aurora as part of EME platform uplift.
Attachment #8572389 -
Flags: approval-mozilla-beta?
Attachment #8572389 -
Flags: approval-mozilla-beta+
Attachment #8572389 -
Flags: approval-mozilla-aurora?
Attachment #8572389 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•