Mark Banner (:standard8) Reporter
	Description • 10 years ago

Bug 1106941 is adding some code to work around the fact that when we don't have a camera on desktop the gUM call currently aborts.

When we get MediaStreamTrack.getSources() functionality the sdk should automatically manage the enumeration and turn off requesting the camera if there isn't one present.

Maire: which bug is the one that'll implement the MediaStreamTrack.getSources (so that we can add it as a dependency.

	Mark Banner (:standard8) Reporter
	Comment 1 • 10 years ago

Jan-Ivar: The SDK currently uses MediaStreamTrack.getSources() to find out if there's video & audio devices present:

http://hg.mozilla.org/mozilla-central/annotate/e5b72a8edb82/browser/components/loop/content/shared/libs/sdk.js#l14076

Is this the right thing to use in the long term, or should we be recommending use of the new mediaDevices enumeration?

	Jan-Ivar Bruaroey [:jib] (needinfo? me)
	Comment 2 • 10 years ago

We should. MediaStreamTrack.getSources() was changed to mediaDevices.enumerateDevices() in the spec more than a year ago [1]. Unfortunately, Google Chrome still uses the old name. Do you know if the SDK relies on adapter.js? I can try to push a polyfill there.

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=22269#c7

	Mark Banner (:standard8) Reporter
	Comment 3 • 10 years ago

Asking TokBox support - is it planned to change the SDK to support the newer mediaDevices.enumerateDevices API at some stage (that has now been landed in FF).

I believe the answer is yes from conversations I've heard previously, but if you've got an approximate timescale that would be useful for our planning as well (this isn't an urgent bug, but a workaround we'd like to be able to remove at some stage).

Thanks.

	:shell escalante
	Comment 4 • 10 years ago

Mark will need info - shell will add to track at monday meeting for timing.

	Mark Banner (:standard8) Reporter
	Comment 5 • 10 years ago

Adding the needinfo this time...

Asking TokBox support - is it planned to change the SDK to support the newer mediaDevices.enumerateDevices API at some stage (that has now been landed in FF).

I believe the answer is yes from conversations I've heard previously, but if you've got an approximate timescale that would be useful for our planning as well (this isn't an urgent bug, but a workaround we'd like to be able to remove at some stage).

Thanks.

	msander
	Comment 6 • 10 years ago

Mark, yes we are planning to support this in the July release. We were waiting for 1046245 to be resolved.

	Mark Banner (:standard8) Reporter
	Comment 7 • 9 years ago

Great, thanks for the information. We can revisit it around that time.

	Mark Banner (:standard8) Reporter
	Comment 8 • 9 years ago

Michael, I believe there's a new version of the sdk out (2.6.4?) now that has the fixes to use media devices. Would we be able to get the new version now?

(and can you confirm the list of changes - the ones on the website seemed quite small, but maybe that's correct).

	msander
	Comment 9 • 9 years ago

Sorry for the delay. I've attached JS SDK v2.6.5 which has an additional change increasing the minimum Firefox version to 38 and the minimum Chrome version to 43. Other than the changes listed on the site, v2.6.x includes undocumented support for simulcast in sessions using our MCU. Since Hello doesn't use the MCU this won't impact you at all.

	msander
	Comment 10 • 9 years ago

New patch for the JS SDK v2.6.7.

Changes in this patch:
* New congestion icon (mcu sessions only)
* Support removal of RTCMediaStream.prototype.stop in Chrome 47.

	Mark Banner (:standard8) Reporter
	Comment 11 • 9 years ago

Comment on attachment 8669055 [details]
webrtc-js-2.6.7.tgz

Thanks Michael, I'm moving this across to bug 1210865 as we decided to split the upgrade up into a separate bug.

	Mark Banner (:standard8) Reporter
	Comment 12 • 8 years ago

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.