Closed
Bug 1138941
Opened 10 years ago
Closed 10 years ago
We should display a better string when we've failed to obtain the camera and video devices
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox40 verified)
Tracking | Status | |
---|---|---|
firefox40 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [strings][devices])
Attachments
(1 file)
(deleted),
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
Following bug 1106941 we will be displaying "Something went wrong" if there's a catastrophic error getting the camera or microphone.
We need to display something better in that case.
For the current link-clicker UI we display: "We could not get access to your microphone or camera. Please reload the page to try again."
However, this is slightly worse-case than that. I would suggest either just "We could not get access to your microphone or camera." or "We could not access any microphone or camera devices."
Note: this would be primarily for desktop, though it could show up on link-clicker is some rare circumstances as well.
Sevaan: any preference of strings here?
Flags: needinfo?(sfranks)
Comment 1•10 years ago
|
||
"We were unable to find any microphone or camera devices." Maybe?
Flags: needinfo?(sfranks) → needinfo?(matej)
Comment 2•10 years ago
|
||
I prefer not to use "we" because it brings up the question of who, exactly, "we" is.
I would suggest one of the following:
No camera or microphone found.
No camera or microphone detected.
(Is it possible that we might detect one but not the other?)
Flags: needinfo?(matej)
Comment 3•10 years ago
|
||
Thanks, I like "No Camera or Microphone found".
Standard8:
> (Is it possible that we might detect one but not the other?)
Flags: needinfo?(standard8)
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Sevaan Franks [:sevaan] from comment #3)
> > (Is it possible that we might detect one but not the other?)
I believe in the case I'm looking at, it would be hard to tell. We will in future be able to tell what's missing.
Flags: needinfo?(standard8)
Assignee | ||
Comment 5•10 years ago
|
||
Updates the appropriate views to display the requested string. This should give users a better change of understanding what's happening.
To test this, I changed the two "if (!sources.Length())" lines in GetUserMediaTask::SelectDevice to negate the statement (i.e. remove the exclamation mark).
Attachment #8585441 -
Flags: review?(dmose)
Assignee | ||
Updated•10 years ago
|
Iteration: --- → 40.1 - 13 Apr
Points: --- → 3
Updated•10 years ago
|
Rank: 21
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [strings][devices]
Comment 6•10 years ago
|
||
Comment on attachment 8585441 [details] [diff] [review]
Display a better string when we've failed to obtain the camera and video devices for Loop.
Review of attachment 8585441 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay! Looks good; one minor nit-pick included, free of charge. :-)
r=dmose
::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +253,5 @@
>
> cannot_start_call_session_not_ready=Can't start call, session is not ready.
> network_disconnected=The network connection terminated abruptly.
> connection_error_see_console_notification=Call failed; see console for details.
> +no_media_failure_message=No Camera or Microphone found
It looks a bit odd to capitalize "Camera" and "Microphone", but not "found".
Attachment #8585441 -
Flags: review?(dmose) → review+
Comment 7•10 years ago
|
||
Should be "No camera or microphone found" like what Matej suggested. I put in the capitals by mistake, sorry!
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5c706289607d
For qe-verify: Test, if possible, on a machine without camera/microphone devices.
Check that a link generator for a room correctly gets a "No camera or microphone found" message.
Also, check that attempting a direct call results in the same message.
Flags: qe-verify+
Target Milestone: --- → mozilla40
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
Will be verified together with bug 1106941.
Comment 11•9 years ago
|
||
Verified fixed on 40.0b4 (Build ID: 20150713153304), under Windows 7 64-bit and Ubuntu 14.04 32-bit - "No camera or microphone found" message is properly displayed, including when performing a FxA call.
You need to log in
before you can comment on or make changes to this bug.
Description
•