Closed Bug 1139005 Opened 10 years ago Closed 10 years ago

Need to check the return value of AutoJSAPI.init in canvas EncodeCallback

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
firefox37 --- wontfix
firefox38 --- wontfix
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

jsapi
(deleted), patch
ayang
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
Attached patch jsapi (deleted) — — Splinter Review
This was causing problems if the callback is called after the window has already been torn down.
Attachment #8572033 - Flags: review?(ayang)
Comment on attachment 8572033 [details] [diff] [review] jsapi Review of attachment 8572033 [details] [diff] [review]: ----------------------------------------------------------------- Thank you! BTW, how do you reproduce this bug? I doubt this bug probably be something like https://crash-stats.mozilla.com/report/index/981be8cb-79ef-4f04-b44d-bc9b22150115.
Attachment #8572033 - Flags: review?(ayang) → review+
Blocks: 1121899
blocking-b2g: --- → 2.2?
As bug 1121899 comment 23, uplift to 2.2+.
blocking-b2g: 2.2? → 2.2+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e83a9eba19f I had a patch that made this happen more often. It was just a coincidence.
Comment on attachment 8572033 [details] [diff] [review] jsapi NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 1139005 User impact if declined: gallery crash in low memory device (256mb) Testing completed: local test is fine. Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: na
Attachment #8572033 - Flags: approval-mozilla-b2g37?
https://hg.mozilla.org/mozilla-central/rev/9e83a9eba19f
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8572033 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: