Closed
Bug 1139805
Opened 10 years ago
Closed 10 years ago
B2G NetworkManager: move NetworkManager.js out of EXTRA_PP_COMPONENTS in moz.build
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(tracking-b2g:backlog, firefox39 fixed)
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
Since we got rid of #ifdefs in NetworkManager, it should no longer be included in EXTRA_PP_COMPONENTS. This will avoid the following warning message when building gecko:
".../gecko/dom/system/gonk/NetworkManager.js: WARNING: no preprocessor directives found"
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8573146 [details] [diff] [review]
patch, v1.
Edgar, may I have your review on this? Thanks.
Attachment #8573146 -
Flags: review?(echen)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8573146 [details] [diff] [review]
patch, v1.
Review of attachment 8573146 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you.
Attachment #8573146 -
Flags: review?(echen) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thank you, Edgar.
try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=681eb7b13bd2
There are some failures, but they are currently marked as known issues in b2g-inbound:
https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=b79a38cf4f65
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
|
||
Updated•10 years ago
|
blocking-b2g: --- → backlog
|
||
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•