Closed Bug 1140345 Opened 10 years ago Closed 10 years ago

Use an image instead of toolbarbutton for the reading view button

Categories

(Firefox :: Theme, defect, P5)

Product:
Firefox
Component:
Theme
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Iteration:
39.2 - 23 Mar
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: dao, Assigned: jaws)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Patch
(deleted), patch
florian
: review+
Details | Diff | Splinter Review
The reader mode button in the location bar is too close to the dropdown arrow as well as adjacent location bar icons when there are any. This could be fixed by addressing bug 1140340 and reverting most of bug 1131458.
Priority: -- → P5
Depends on: 1140233
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attached patch Patch (deleted) — — Splinter Review
Attachment #8580975 - Flags: review?(gijskruitbosch+bugs)
Attachment #8580975 - Flags: review?(gijskruitbosch+bugs) → review?(florian)
Comment on attachment 8580975 [details] [diff] [review] Patch Review of attachment 8580975 [details] [diff] [review]: ----------------------------------------------------------------- The patch looks good. I think we should show the blue icon for the :active state on Mac for consistency with the other icons around it. Also, could you please rephrase the bug summary so that it relates more obviously to what the patch does?
Attachment #8580975 - Flags: review?(florian) → review+
Summary: Reader mode button lacks padding → Use an image instead of toolbarbutton for the reading view button
https://hg.mozilla.org/integration/fx-team/rev/f278852df165
Blocks: 1132074
Iteration: --- → 38.3 - 23 Feb
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
Iteration: 38.3 - 23 Feb → 39.2 - 23 Mar
https://hg.mozilla.org/mozilla-central/rev/f278852df165
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Comment on attachment 8580975 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: reader mode [User impact if declined]: broken muscle memory for tabbing from location bar to search box [Describe test coverage new/current, TreeHerder]: landed on central, manual qa testing [Risks and why]: none expected, uses same approach for location-bar buttons as before [String/UUID change made/needed]: none
Attachment #8580975 - Flags: approval-mozilla-aurora?
Comment on attachment 8580975 [details] [diff] [review] Patch (branch patch needed)
Attachment #8580975 - Flags: approval-mozilla-aurora?
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6) > Comment on attachment 8580975 [details] [diff] [review] > Patch > > (branch patch needed) A branch patch might not be needed once bug 1131457 is uplifted.
Blocks: 1134658
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: