Closed Bug 1140435 Opened 10 years ago Closed 10 years ago

Allow JS code to provide an async stack when calling a function

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(3 files)

Part 1 - Add the asyncCause and asyncCaller properties to nsIStackFrame
(deleted), patch
Paolo
: review+
bzbarsky
: review+
Details | Diff | Splinter Review
Part 2 - Allow JS code to provide an async stack when calling a function
(deleted), patch
Paolo
: review+
Details | Diff | Splinter Review
adb logcat on boot -zte open c
(deleted), text/plain
Details
See bug 1083359 for all the details.
Hmm, I guess this is one of those followup bugs I asked about. ;) What are the DOM bits that need doing here?
Carrying over r+ from bug 1083359 comment 74.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #8573989 - Flags: review+
These patches are rebased on top of bug 1122238. Boris, I think copying the new structure of the accessors was straightforward, but if you want to take a look feel free to.
Flags: needinfo?(bzbarsky)
Depends on: 1122238
Comment on attachment 8573989 [details] [diff] [review] Part 1 - Add the asyncCause and asyncCaller properties to nsIStackFrame You need to add mAsyncCaller to the NS_IMPL_CYCLE_COLLECTION for StackFrame, right?
Flags: needinfo?(paolo.mozmail)
Comment on attachment 8573989 [details] [diff] [review] Part 1 - Add the asyncCause and asyncCaller properties to nsIStackFrame Apart from the CC bit, this looks good.
Flags: needinfo?(bzbarsky)
Attachment #8573989 - Flags: review+
Comment on attachment 8573991 [details] [diff] [review] Part 2 - Allow JS code to provide an async stack when calling a function >+ JS_ReportError(cx, "Invalid argument"); No real need for that, since XPConnect will do the right thing with NS_ERROR_INVALID_ARG. This looks great.
Thanks, patches updated! If I leave the following JS_ReportError, would the more specific message be propagated? JS_ReportError(cx, "Must use a native JavaScript stack frame"); return NS_ERROR_INVALID_ARG;
Flags: needinfo?(paolo.mozmail)
Tryserver build with updated patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=18a89cb5764c
> If I leave the following JS_ReportError, would the more specific message be propagated? Yes, it should be.
Phil, something happened on the last fx-team -> mc merge because nothing got marked as fixed (from https://hg.mozilla.org/mozilla-central/rev/65d1053d7959 to https://hg.mozilla.org/mozilla-central/rev/bdacb3e22b54)
Flags: needinfo?(philringnalda)
https://hg.mozilla.org/mozilla-central/rev/750120b03c83 https://hg.mozilla.org/mozilla-central/rev/bdacb3e22b54
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
I'd guess what happened was "I completely forgot to run mcMerge on it," thanks for noticing.
Flags: needinfo?(philringnalda)
Attached file adb logcat on boot -zte open c (deleted) —
Hello, It's seem (with git bisect) your second patch completely break boot on ZTE OPEN C :(
(In reply to dattaz from comment #15) > It's seem (with git bisect) your second patch completely break boot on ZTE > OPEN C :( Can you file a separate bug on this issue? It should be investigated by someone familiar with Firefox OS.
Blocks: 1144353
See comment 16.
Flags: needinfo?(taz)
done : https://bugzilla.mozilla.org/show_bug.cgi?id=1144622
Flags: needinfo?(taz)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: