Closed
Bug 1140982
Opened 10 years ago
Closed 10 years ago
[Stingray] [Component] Create web component - smart-icons
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
Attachments
(1 file)
Smart-icons is extract from https://github.com/mozilla-b2g/gaia/tree/master/tv_apps/tv_shared/font
Because we are going to remove tv_shared folder.
|
Assignee | |
Updated•10 years ago
|
Summary: Bug 1133424 - [Stingray] [Component] Create web component - smart-icons → [Stingray] [Component] Create web component - smart-icons
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Hi John,
This patch extract gaia-device-icon as a web component managed by bower and rename to smart-icons.
Please help to review the patch.
Attachment #8575080 -
Flags: review?(im)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8575080 [details]
pull request
Since Rex is going to move components to github.com/gaia-components/,
I think it is better for Rex to review this patch.
Hi Rex,
This patch extract gaia-device-icon as a web component managed by bower and rename to smart-icons.
Please help to review the patch.
Attachment #8575080 -
Flags: review?(im) → review?(rexboy)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8575080 [details]
pull request
Looks good to me
And we also need to update Gaia repository later.
Attachment #8575080 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks, Rex.
The work on Gaia part is in bug 1138870.
And I think we might also need to move smart-icons into gaia-components, which is filed as bug 1141425.
|
|
Assignee | |
Comment 5•10 years ago
|
||
Landed on smart-icons:master
https://github.com/smart-components/smart-icons/commit/fce7d48cb105690e6a079a6d058080bd8d2a1d96
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•