Closed Bug 114100 Opened 23 years ago Closed 15 years ago

investigate (detail==eRuleNone) check in nsRuleNode::WalkRuleTree

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dbaron, Unassigned)

References

Details

(Keywords: perf)

Attachments

(1 file)

This bug is split off from bug 111815. In nsRuleNode::WalkRuleTree, I'm not usre why we need to check that |detail == eRuleNone| before skipping rule nodes that have the inherit bit set for the struct? Doesn't having the inherit bit set for a struct mean that they have nothing to contribute? (I noticed removing this check messed up table borders.) This is noted with an XXXldb in the function from the patch for bug 111815. Removing this check (which would slightly improve performance) messes up table borders. I'm wondering if this issue is due to a bug in the attribute mapping function for the table element.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.1beta
cc'ing myself
Target Milestone: mozilla1.1beta → mozilla1.2alpha
Target Milestone: mozilla1.2alpha → Future
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: ian → style-system
I was the one who submitted this, but I cannot use firefox to access the site, because it will crash one out of every two times I go to it on average.
Keywords: perf
Depends on: 43178
(In reply to comment #0) > Removing this check (which would slightly improve performance) messes up table > borders. I'm wondering if this issue is due to a bug in the attribute mapping > function for the table element. In other words, fixing this may depend on bug 211636.
Depends on: 211636
Attached patch patch (deleted) — Splinter Review
This passes reftests, but I'd still like to think about it a little more.
Attachment #371559 - Flags: review?(bzbarsky)
Did you figure out what the table borders issue was?
To be clear, the review is waiting on an answer to comment 5.
I don't know, but there have been substantial improvements to the table attribute mapping functions in the past seven and a half years.
Comment on attachment 371559 [details] [diff] [review] patch Fair enough. This looks fine to me.
Attachment #371559 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 15 years ago
OS: Linux → All
Priority: P2 → P4
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: Future → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: