Closed Bug 1141061 Opened 10 years ago Closed 8 years ago

Notification bar: close icon should be inverted on outdated plugin notification bars

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1260103
Tracking Status
firefox36 --- unaffected
firefox37 --- affected
firefox38 --- affected
firefox39 --- affected

People

(Reporter: noni, Unassigned)

References

Details

The close icon should be inverted on black notification bars (screenshot: http://i.imgur.com/Wuk5MDS.png). This is only Windows and Linux specific. It was fixed on Mac, please see bug 1047977.
Drew, bug 1130850 will be uplifted to 37. Can you take this one and fix in the same release as well?
Flags: needinfo?(adw)
Flags: firefox-backlog?
(In reply to Cornel Ionce [QA] from comment #0) > It was fixed on Mac, please see bug 1047977. It was only fixed on Mac since it was the only platform which used black notification bars for @type=info. It looks like this notification bar is using custom styling in plugin-doorhanger.inc.css :( One-off style changes cause maintenance issues like this which we should stop doing unless absolutely necessary.
Summary: Notification bar: close icon should be inverted on black notification bars → Notification bar: close icon should be inverted on outdated plugin notification bars
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #1) > Drew, bug 1130850 will be uplifted to 37. Can you take this one and fix in > the same release as well? I don't think bug 1130850 is related to this bug and I don't know why Cornel mentioned it in that bug. As I understand it this bug has been around for a while, ever since plugin-doorhanger.inc.css started using a custom background for this notification bar, like Matt says. So I'm not planning to work on this.
Flags: needinfo?(adw)
I think he referenced it as it is related from a UX perspective. Bug 1130850 is about the text being hard to read in the notification bar. This bug is about the X being hard to see in the notification bar. I certainly don't have all of the background on this bug but it is currently flagged as a regression in 37. We have two weeks to fix the regression before we ship it on Windows. I don't think this is a major issue but if there is a localized and simple fix that we can put in 37 and later pursue a proper fix (like what Matt wrote in comment 2), I think that's worth doing. Philipp - Can you comment on the severity of this bug from a UX perspective?
Flags: needinfo?(philipp)
Hmm, where's it flagged as a regression? As I said, it's not a regression at all as I understand it. Bug 1130850 and even bug 1047977 really have nothing to do with this except for being about similar things.
In terms of severity it's pretty low. How does it weigh against the implementation cost? Is this a hard thing to fix?
Flags: needinfo?(philipp)
// I was going to file this bug along with the issue described below, because it's really small CSS change, and could be handled in 1 bug. I also noticed that Notification's bottom border is white(lightgray?) on all themes. That causes "color jump" black-white-black if page content is black. So it would be nice if that border was dark, just like notification itself. That wouldn't cause "color jump" for pages with white background. > screenshot: https://dl.dropboxusercontent.com/s/vwepmfpc3ycjfuf/bug%201141061%20comment%207%20%2B%202015.10.26%2002-18-26.png?dl=0
I should start reporting duplicate bugs too.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.