Closed
Bug 1141607
Opened 10 years ago
Closed 10 years ago
outline-color doesn't adapt to high contrast colors (it's always black in h-c themes)
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ntim, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Comment 1•10 years ago
|
||
For posterity, I *think* the bug comes from this block of code, http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSDataBlock.cpp#151
Although Gijs has pointed out that this would mean that the background-color would take the high-contrast color but the text color wouldn't, so I'm not so sure.
Updated•10 years ago
|
Points: --- → 5
Priority: -- → P3
Reporter | ||
Updated•10 years ago
|
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Comment 2•10 years ago
|
||
No colors ever work in HCM. We just end up picking nice ones for foreground/background, but we seem to pick the background color for outline, instead of the foreground. I don't know why this is.
Component: Disability Access APIs → Layout
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Component: Layout → CSS Parsing and Computation
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8598769 -
Flags: review?(dbaron)
Comment 4•10 years ago
|
||
Comment on attachment 8598769 [details] [diff] [review]
Fix the initial value of outline-color to actually be correct
I wonder how we missed this for so long. (It seems to predate the rule tree landing.)
Attachment #8598769 -
Flags: review?(dbaron) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b899a9295076 for mochitest-5 orange:
https://treeherder.mozilla.org/logviewer.html#?job_id=9382841&repo=mozilla-inbound
Flags: needinfo?(bzbarsky)
Comment 7•10 years ago
|
||
Yeah, looks like the big switch statement in:
$("one").addEventListener("transitionend",
function(event) {
switch (event.propertyName) {
needs a case for outline-color just like the ones for everything other than border-right-color.
Assignee | ||
Comment 9•10 years ago
|
||
> Yeah, looks like the big switch statement in:
That, plus adding it to the block with explicit styles passes try.
Flags: needinfo?(bzbarsky)
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 11•10 years ago
|
||
One thing I noticed while auditing -- the patch in bug 1141607 should have added a started_test() call -- as, probably, should some other changes to the test in the past. I think we're two short for the listener on #one, and also two short for the listener on the root. But we're two over for #seven since that listener doesn't call finished_test (and also doesn't check for duplicate events on ::after).
It might be worth seeing if adding the necessary calls makes failures that are currently intermittent more reliable.
Comment 12•10 years ago
|
||
Er, I meant that for bug 1156451, although it's not entirely inappropriate here.
You need to log in
before you can comment on or make changes to this bug.
Description
•