Closed
Bug 1142433
Opened 10 years ago
Closed 10 years ago
Duration not properly read from MEHD atom
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: jya, Assigned: jya)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
ajones
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
Introduced in bug 1120075
It appears that the duration found in the movie extend header is defined according to the timescale in the movie header (mvhd) atom.
And not in milliseconds as first assumed (all the samples I had use a timescale = 1000)
Assignee | ||
Comment 1•10 years ago
|
||
properly adjust duration according to movie header timescale
Attachment #8576546 -
Flags: review?(ajones)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8576546 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
This cause a lot of webref test to fail. IT appears that was cause we were incorrectly calculating durations before. So few tests now passes.
Comment 4•10 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/aa48e92f7e57 - looks like the best two places to catch the failures are OS X 10.10 opt, in media-source/mediasource-append-buffer.html like https://treeherder.mozilla.org/logviewer.html#?job_id=7560429&repo=mozilla-inbound and Windows 8 opt in media-source/mediasource-remove.html like https://treeherder.mozilla.org/logviewer.html#?job_id=7566449&repo=mozilla-inbound
Assignee | ||
Comment 5•10 years ago
|
||
Update webref. We still timeout due to bug 1128332 that now occurs on all platforms.
Attachment #8577992 -
Flags: review?(karlt)
Updated•10 years ago
|
Attachment #8577992 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a7425df3572a
https://hg.mozilla.org/mozilla-central/rev/864a62ab3500
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Assignee | ||
Comment 8•10 years ago
|
||
This bugs needs to be uplifted as otherwise webref tests will now fail (now that they have been re-activated due to bug 1144509)
Flags: needinfo?(giles)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8576546 [details] [diff] [review]
Properly scale duration found in movie extend header box
Approval Request Comment
[Feature/regressing bug #]:1142433
[User impact if declined]:Tests recently re-enabled will fail.
[Describe test coverage new/current, TreeHerder]:Been on m-c for over a week.
[Risks and why]: Low. The tests were re-enabled, previously disabled. Problem was always there
[String/UUID change made/needed]:none
Attachment #8576546 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•10 years ago
|
||
the approval request is for both patches.
Updated•10 years ago
|
status-firefox38:
--- → affected
Updated•10 years ago
|
Attachment #8576546 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/07e8fa9ef9e7
https://hg.mozilla.org/releases/mozilla-aurora/rev/558460c05b39
Part 2 included a revert of rev 0b7762fb7639 as well.
Flags: in-testsuite+
Updated•10 years ago
|
Flags: needinfo?(giles)
You need to log in
before you can comment on or make changes to this bug.
Description
•