Closed
Bug 1142495
Opened 10 years ago
Closed 10 years ago
ICC build error on emulator L
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: edgar)
References
Details
Attachments
(1 file)
(deleted),
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
Debug builds on emulator l fail with a build error in the RIL code. The log is at [1].
[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&exclusion_profile=false&filter-searchStr=b2g_mozilla-central_emulator-l
Reporter | ||
Comment 1•10 years ago
|
||
Hi Hsinyi, Edgar,
we're close to enabling emulator L builds. Can you take a look? Looks like a trivial build issue in the RIL stack.
Flags: needinfo?(htsai)
Flags: needinfo?(echen)
Updated•10 years ago
|
Summary: IICC build error on emulator L → ICC build error on emulator L
Comment 2•10 years ago
|
||
Emulator L jobs can be run on Try using the |try: -b do -p emulator-l -u none -t none| syntax. They're hidden by default, so you'll need to click the "Show/hide hidden jobs" toggle on Treeherder (or just add &exclusion_profile=false to the URL in the location bar).
Assignee | ||
Comment 3•10 years ago
|
||
Looks like same as https://bugzilla.mozilla.org/show_bug.cgi?id=1114935#c42. I will take a look.
Assignee: nobody → echen
Flags: needinfo?(htsai)
Flags: needinfo?(echen)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8576716 [details] [diff] [review]
Patch, v1
Review of attachment 8576716 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Edgar Chen [:edgar][:echen] (OOO 3/21~4/6) from comment #5)
> Try:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=0c1fa9beec0f&exclusion_profile=false
Emulator-l debug build is green with applying this patch.
Hi Hsinyi, would you mind reviewing this patch?
Thank you.
Attachment #8576716 -
Flags: review?(htsai)
Comment 7•10 years ago
|
||
Comment on attachment 8576716 [details] [diff] [review]
Patch, v1
Review of attachment 8576716 [details] [diff] [review]:
-----------------------------------------------------------------
Oh, yes Orz
Attachment #8576716 -
Flags: review?(htsai) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•