Closed
Bug 1142865
Opened 10 years ago
Closed 10 years ago
Remove the parent argument from NewObjectWithGroup
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8577078 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8577376 -
Flags: review?(jwalden+bmo)
Assignee | ||
Updated•10 years ago
|
Attachment #8577078 -
Attachment is obsolete: true
Attachment #8577078 -
Flags: review?(jwalden+bmo)
Comment 3•10 years ago
|
||
Comment on attachment 8577376 [details] [diff] [review]
Remove the parent argument from NewObjectWithGroup
Review of attachment 8577376 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/vm/UnboxedObject.cpp
@@ +507,1 @@
> allocKind, newKind);
UPO *res =
NewObjectWithGroup<UPO>(...);
should amke this more readable, I think.
Attachment #8577376 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•