Closed
Bug 1142933
Opened 10 years ago
Closed 9 years ago
[B2G] New audio channel type for system usages
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
FxOS-S3 (24Jul)
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
We defined the UX sound spec in the Bug1068219. The spec mentioned that we need a audio type "system" to handle the usages of UI sound, keyboard, dial pad, screen unlock and screenshot. Now these usages are implemented by "notification" type, but their sound behaviors don't correspond to the sound spec. Therefore, we need to create a new audio channel type - "system".
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → alwu
Assignee | ||
Comment 1•10 years ago
|
||
Hi, Ehsan, Sorry to bother you, Could you help me review this patch? This patch implements the new audio channel type - "system", and it can ensure we get the correct sound behaviors which are defined in UX sound spec. ps. Sound behaviors are defined in the attachment of Bug1068219, page 12. Thanks a lot :)
Attachment #8577884 -
Flags: review?(ehsan)
Comment 2•10 years ago
|
||
Comment on attachment 8577884 [details] [diff] [review] Add new audio channel type - "system" Review of attachment 8577884 [details] [diff] [review]: ----------------------------------------------------------------- I prefer Andrea to review this, but he is out this week. If this can't wait until he gets back, please let me know!
Attachment #8577884 -
Flags: review?(ehsan) → review?(amarchesini)
Assignee | ||
Comment 3•10 years ago
|
||
Hi, Ehsan, It's not very emergency, I will wait for him coming back. Thanks you :)
Comment 5•10 years ago
|
||
Comment on attachment 8577884 [details] [diff] [review] Add new audio channel type - "system" Review of attachment 8577884 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/audiochannel/nsIAudioChannelAgent.idl @@ +44,1 @@ > interface nsIAudioChannelAgent : nsISupports change the UUID of this interface. ::: dom/media/CubebUtils.cpp @@ +183,5 @@ > return CUBEB_STREAM_TYPE_VOICE_CALL; > case dom::AudioChannel::Ringer: > return CUBEB_STREAM_TYPE_RING; > + case dom::AudioChannel::System: > + return CUBEB_STREAM_TYPE_SYSTEM; where is this defined? ::: dom/system/gonk/AudioManager.cpp @@ +732,5 @@ > case AudioChannel::Alarm: > status = SetStreamVolumeIndex(AUDIO_STREAM_ALARM, aIndex); > break; > + case AudioChannel::System: > + status = SetStreamVolumeIndex(AUDIO_STREAM_SYSTEM, aIndex); Where is this defined?
Attachment #8577884 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #5) > Alwu, where do we use 'notification'? As I know, We use the 'notification' in the dialer :) https://github.com/mozilla-b2g/gaia/blob/master/shared/js/dialer/keypad.js#L201 > > ::: dom/audiochannel/nsIAudioChannelAgent.idl > @@ +44,1 @@ > > interface nsIAudioChannelAgent : nsISupports > > change the UUID of this interface. > Sorry, I don't very understand the UUID. Whether we need to change it when every time we change the interface? > ::: dom/media/CubebUtils.cpp > @@ +183,5 @@ > > + case dom::AudioChannel::System: > > + return CUBEB_STREAM_TYPE_SYSTEM; > > where is this defined? > In Cubeb.h. https://dxr.mozilla.org/mozilla-central/source/media/libcubeb/include/cubeb.h?from=cubeb.h#106 > ::: dom/system/gonk/AudioManager.cpp > @@ +732,5 @@ > > + case AudioChannel::System: > > + status = SetStreamVolumeIndex(AUDIO_STREAM_SYSTEM, aIndex); > > Where is this defined? In AudioSystem.h. https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/android_audio/AudioSystem.h#68
Flags: needinfo?(alwu)
Comment 7•10 years ago
|
||
> Sorry, I don't very understand the UUID.
> Whether we need to change it when every time we change the interface?
[uuid(2b0222a5-8f7b-49d2-9ab8-cd01b744b23e)]
interface nsIAudioChannelAgent : nsISupports
Anytime you change an IDL interface, change the UUID.
Assignee | ||
Comment 8•10 years ago
|
||
Try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=2626e94ab030
Attachment #8577884 -
Attachment is obsolete: true
Attachment #8583738 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Sorry to change the flag frequently, this issue still need to wait for Bug1113086.
Depends on: 1113086
Comment 10•10 years ago
|
||
I am under the impression that bug 1113086 is ready to go and we need to land it *and* this bug (+ perhaps bug 1100822) at the same time. Alternatively, is there a way to land pieces independently?
Flags: needinfo?(amarchesini)
Flags: needinfo?(alwu)
Assignee | ||
Comment 11•10 years ago
|
||
I think we should land the Bug1100822 first, then Bug1113086. After that, landing other patches (This bug + Bug1129882).
Flags: needinfo?(alwu)
Comment 12•10 years ago
|
||
Thanks, Alastor. The bug hierarchy appears correct so I guess once bug 1100822 gets r+ and lands, bug 1113086 can land and so on.
Updated•10 years ago
|
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 13•9 years ago
|
||
Rebase, and here is the try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=29c65c3a7e97
Attachment #8583738 -
Attachment is obsolete: true
Assignee | ||
Comment 14•9 years ago
|
||
Hi, Ryan, The failed test case is related with the layout, so I think it might not caused by my patch. Thanks!
Keywords: checkin-needed
Comment 15•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/609926a39887
Keywords: checkin-needed
Comment 16•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/609926a39887
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S3 (24Jul)
Assignee | ||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•