Maybe only when on a different tab than Performance, like the debugger when it's paused, but this would be useful when you have the console open, and a profile/profileEnd cycle is called so the user knows the performance tool is recording something.

Not specifically blocking v2.

(got a patch for this for v2)

This looks cool.

Comment on attachment 8598311 [details] [diff] [review] 1143027-perf-highlight.patch Review of attachment 8598311 [details] [diff] [review]: ----------------------------------------------------------------- Loving it. ::: browser/devtools/performance/modules/front.js @@ +37,5 @@ > // Events to pipe from PerformanceActorsConnection to the PerformanceFront > const CONNECTION_PIPE_EVENTS = [ > "console-profile-start", "console-profile-ending", "console-profile-end", > + "timeline-data", "profiler-already-active", "profiler-activated", "recording-started", > + "recording-stopped" Nit: recording-started and recording-stopped would be more readable on their own line. ::: browser/devtools/performance/panel.js @@ +33,5 @@ > */ > open: Task.async(function*() { > this.panelWin.gToolbox = this._toolbox; > this.panelWin.gTarget = this.target; > + this._onRecordingStartAndStop = this._onRecordingStartAndStop.bind(this); Nit: or, not and.

nits fixed

remote: https://hg.mozilla.org/integration/fx-team/rev/ef2bdaf2121e remote: https://hg.mozilla.org/integration/fx-team/rev/d915bf908fe7 remote: https://hg.mozilla.org/integration/fx-team/rev/285639a4d08c remote: https://hg.mozilla.org/integration/fx-team/rev/757ec9880c5b