User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.76 Safari/537.36 Steps to reproduce: Invoke make install in js/src Actual results: Symlinks instead of file copies are placed into the destination directory. Expected results: Update dist_include manifest with prefix "2" instead of "1". See https://bugs.gentoo.org/show_bug.cgi?id=540876

Comment on attachment 8782838 [details] [diff] [review] bug1143421.patch Hello Mike could you review this? It's a Spidermonkey bug while relevant codes are in /python/mozbuild/

Comment on attachment 8782838 [details] [diff] [review] bug1143421.patch Review of attachment 8782838 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/action/process_install_manifest.py @@ +59,4 @@ > manifest |= InstallManifest(path=path) > > copier = FileCopier() > + manifest.populate_registry(copier, defines_override=defines, no_symlinks=no_symlinks) Instead of increasing the API surface for InstallManifest, I'd create a subclass here with an overridden add_symlink that just calls add_copy, then use that subclass instead of InstallManifest when no_symlinks is true.

Sorry for being late. I just messed up my build system and I pulled from HG again. Is this patch OK?

Comment on attachment 8783846 [details] [diff] [review] bug1143421_ver2.patch Review of attachment 8783846 [details] [diff] [review]: ----------------------------------------------------------------- Please update the patch as per the comment below, as well as adding some information for checkin: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F ::: python/mozbuild/mozpack/manifests.py @@ +400,5 @@ > + > + > +class InstallManifestNoSymlinks(InstallManifest): > + """Like InstallManifest, but files are never installed as symbolic links. > + Instead, they are always copied. This is useful for distribution packagers. The last sentence is not necessary.

Updated. Thanks for all kind instructions!

Re-generate the patch with `hg export qtip`. Sorry for the previous noise.

Hi Mike, is it OK to move on?

Comment on attachment 8784721 [details] [diff] [review] bug1143421_ver4.patch Carrying over r+

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd4cbc33bad4 install file copies instead of symlinks for Spidermonkey. r=glandium