With console.profile recording, we ultimately need to get additional start times from these actors, as we can have multiple recordings at once with different start/stop times. We can have a separate "getTime" method on these actors, or can have subsequent "start" calls just return a time if its already recording (currently they bail out if already recording, so this just provides a way to get the accurate timing.) Probably should be uplifted to Fx38.

Thoughts on uplifting this? Should we do the same for stop methods, even though we don't currently use them? https://treeherder.mozilla.org/#/jobs?repo=try&revision=7032b1d7e7fc

Comment on attachment 8578336 [details] [diff] [review] 1143915-start-actors.patch Review of attachment 8578336 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/server/actors/timeline.js @@ +243,3 @@ > } > this._isRecording = true; > this._startTime = this.docShells[0].now(); While we're at it, let's remove the `this._startTime`, since it's not used anywhere anymore.

Also removed this._startTime

Fixes failure https://treeherder.mozilla.org/logviewer.html#?job_id=2309320&repo=fx-team

Comment on attachment 8579525 [details] [diff] [review] 1143915-2-fix-allocations-test.patch https://hg.mozilla.org/integration/fx-team/rev/3d5b8440fdf4

https://hg.mozilla.org/mozilla-central/rev/58aa499dc005 https://hg.mozilla.org/mozilla-central/rev/3d5b8440fdf4