Closed
Bug 1143939
Opened 10 years ago
Closed 10 years ago
Add single item delete to about:passwords context menu
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox39 verified)
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | verified |
People
(Reporter: liuche, Assigned: liuche)
References
Details
Attachments
(1 file, 1 obsolete file)
Deletion should be part of the context menu for a password item.
|
||
Comment 1•10 years ago
|
||
By design, I have placed the "Delete" function inside the actual login. Users have to click into an "edit mode" before they get the option to "delete".
|
||
Updated•10 years ago
|
Summary: Add single item delete to context menu → Add single item delete to about:passwords context menu
|
Assignee | |
Comment 2•10 years ago
|
||
Talked with :antlam, and we'll actually have Delete as a context menu item, and eliminate the details page altogether. Clicking delete will display a confirmation dialog.
|
|
Assignee | |
Comment 3•10 years ago
|
||
/r/6175 - Bug 1143939 - Add single-item delete to about:passwords context menu. r=ally
Pull down this commit:
hg pull review -r 93e935db293cc4261039c485706304e7726c14e2
Attachment #8584085 -
Flags: review?(ally)
|
||
Updated•10 years ago
|
Attachment #8584085 -
Flags: review?(ally) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8584085 [details]
MozReview Request: bz://1143939/liuche
https://reviewboard.mozilla.org/r/6173/#review5185
Ship It!
::: mobile/android/chrome/content/aboutPasswords.js
(Diff revision 1)
> + // Corresponds to "confirm" button.
thank you for adding a comment for the magic number
|
|
Assignee | |
Comment 5•10 years ago
|
||
Target Milestone: --- → Firefox 39
|
||
Comment 6•10 years ago
|
||
Assignee: nobody → liuche
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
|
||
Comment 7•10 years ago
|
||
Tested with:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 39.0a1 (2015-03-30)
Tapping on an item from about:passwords list will invoke the context menu. "Delete" is the last option present and choosing it will display a confirmation dialog."Delete this login?" with two buttons: "Cancel" and "OK".
|
|
Assignee | |
Comment 8•9 years ago
|
||
Attachment #8584085 -
Attachment is obsolete: true
Attachment #8619781 -
Flags: review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•