Closed
Bug 1144231
Opened 10 years ago
Closed 10 years ago
browser_polaris_prefs.js doesn't cleanup the preference at the end of the test
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
jmaher
:
review+
jmaher
:
feedback+
|
Details | Diff | Splinter Review |
in bug 1081343, browser_polaris_prefs.js was added. While testing stuff locally, I ran into this test case as failing when run a second time, this is because the prefs are not reset at the end.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8578767 [details] [diff] [review]
cleanup preferences at the end of browser_polaris_prefs.js (1.0)
On line 45, just add:
registerCleanupFunction(function () {
Services.prefs.clearUserPref(POLARIS_ENABLED);
});
Attachment #8578767 -
Flags: review?(tkolodziejski) → review-
|
|
||
Comment 3•10 years ago
|
||
Oh no, not on that line. One sec.
|
|
||
Comment 4•10 years ago
|
||
Just add that to line 40 I guess.
|
|
Assignee | |
Comment 5•10 years ago
|
||
doing what is similar to requested in previous review feedback.
Attachment #8578767 -
Attachment is obsolete: true
Attachment #8578960 -
Flags: review?(gavin.sharp)
|
|
||
Comment 6•10 years ago
|
||
I realized my suggestion wasn't quite right either so figured the easiest counter point was in the form of a patch. Feel free to just push this assuming it works for you.
Attachment #8578960 -
Attachment is obsolete: true
Attachment #8578960 -
Flags: review?(gavin.sharp)
Attachment #8578984 -
Flags: feedback?(jmaher)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8578984 [details] [diff] [review]
patch
Review of attachment 8578984 [details] [diff] [review]:
-----------------------------------------------------------------
this works great, I will land it!
Attachment #8578984 -
Flags: review+
Attachment #8578984 -
Flags: feedback?(jmaher)
Attachment #8578984 -
Flags: feedback+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in
before you can comment on or make changes to this bug.
Description
•