Closed
Bug 1144513
Opened 10 years ago
Closed 10 years ago
[gonk-lmr1] Adapt RTSPSource.cpp
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(firefox37 wontfix, firefox38 wontfix, firefox39 fixed, b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
People
(Reporter: m1, Assigned: jhao)
References
Details
(Whiteboard: [caf priority: p2][CR 809997])
Attachments
(1 file)
|
(deleted),
patch
|
ethan
:
review+
bajaj
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
DISCONTINUITY_SEEK [1] has disappeared from L MR 1. netwerk/protocol/rtsp/rtsp/RTSPSource.cpp can probably be update to simply use DISCONTINUITY_TIME instead.
[1] http://androidxref.com/5.0.0_r2/xref/frameworks/av/media/libstagefright/mpeg2ts/ATSParser.h#44
[2] http://androidxref.com/5.1.0_r1/diff/frameworks/av/media/libstagefright/mpeg2ts/ATSParser.h?r2=%2Fframeworks%2Fav%2Fmedia%2Flibstagefright%2Fmpeg2ts%2FATSParser.h%40fef808d42a9c94b0b5ef3c3d5fb0a090edbc42da&r1=%2Fframeworks%2Fav%2Fmedia%2Flibstagefright%2Fmpeg2ts%2FATSParser.h%409bf32f06e8971c1d3eb4fc5edd74b69557f97212
|
||
Comment 1•10 years ago
|
||
Hi Vincent,
We need your help to find an owner for this issue. Please route this to the appropriate person.
Thanks,
Mike
Flags: needinfo?(vchang)
|
||
Comment 2•10 years ago
|
||
Jonathan, please help to check this.
Assignee: nobody → jhao
Flags: needinfo?(vchang)
|
||
Updated•10 years ago
|
Whiteboard: [CR 809997]
|
|
||
Updated•10 years ago
|
Whiteboard: [CR 809997] → [caf priority: p2][CR 809997]
|
Assignee | |
Comment 3•10 years ago
|
||
Per Comment 1, ATSParser::DISCONTINUITY_SEEK was removed.
Originally, it was set to be equal to ATSParser::DISCONTINUITY_TIME, so we use the latter now instead.
Hi Ethan. Could you please review the patch? Thanks.
Attachment #8579898 -
Flags: review?(ettseng)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8579898 [details] [diff] [review]
update-RTSPSource.patch
Review of attachment 8579898 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for your patch. :)
Attachment #8579898 -
Flags: review?(ettseng) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
|
Reporter | |
Comment 8•10 years ago
|
||
Comment on attachment 8579898 [details] [diff] [review]
update-RTSPSource.patch
Needed for an L MR1 gonk with v2.2
Attachment #8579898 -
Flags: approval-mozilla-b2g37?
|
|
Reporter | |
Comment 9•10 years ago
|
||
(btw. thanks guys)
|
||
Updated•10 years ago
|
Attachment #8579898 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
|
|
||
Comment 10•10 years ago
|
||
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox37:
--- → wontfix
status-firefox38:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•