Closed
Bug 1144615
Opened 10 years ago
Closed 10 years ago
Add playback rate selection to the animation inspector panel
Categories
(DevTools :: Inspector: Animations, defect)
DevTools
Inspector: Animations
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
Details
Attachments
(3 files, 1 obsolete file)
When platform bug 1120339 gets resolved, we'll be able to control animations' playback rate via AnimationPlayer objects.
Which means we'll be able to expose this to devtools users through the animation inspector panel.
Assignee | ||
Comment 1•10 years ago
|
||
When bug 1120339 is fixed, the UI will first need to check that the setPlaybackRate method exists on the actor (as the rest of the feature detection is done on the front-end).
Also, on top of adding a UI control to change the rate, this same control should correctly the current rate when the player widget is first displayed (the rate could have been changed in content prior to the widget being displayed).
Assignee | ||
Comment 2•10 years ago
|
||
My plan is to add a small drop-down button next to the play/pause, rewind, fforward buttons. It would show the current rate, and on click would display a list of presets to choose from.
Assignee | ||
Comment 3•10 years ago
|
||
/r/6527 - Bug 1144615 - 1 - Minor css fixes in animation panel
/r/6529 - Bug 1144615 - 2 - Adds a playbackRate selector widget to the animation panel
/r/6531 - Bug 1144615 - 3 - Tests for the playbackRate selection UI in the animation panel
Pull down these commits:
hg pull -r 483804d08a30525b728be61ddac41bef30c16715 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8587290 -
Flags: review?(vporof)
Attachment #8587290 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8587290 [details]
MozReview Request: bz://1144615/pbrosset
/r/6527 - Bug 1144615 - 1 - Minor css fixes in animation panel
/r/6529 - Bug 1144615 - 2 - Adds a playbackRate selector widget to the animation panel
/r/6531 - Bug 1144615 - 3 - Tests for the playbackRate selection UI in the animation panel
Pull down these commits:
hg pull -r f806895ea2e94c9dc5b78f06f268283b9f55f309 https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Comment 6•10 years ago
|
||
Rebased changesets on top of latest fx-team.
Comment 7•10 years ago
|
||
Updated•10 years ago
|
Attachment #8587290 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Landed part 1: https://hg.mozilla.org/integration/fx-team/rev/2bb927ec6786
Keywords: leave-open
Comment 9•10 years ago
|
||
I have no idea how to use mozreview. You damn kids and your new tools that I need to learn.
Consider this an r+.
Updated•10 years ago
|
Attachment #8587290 -
Flags: review?(vporof) → review+
Comment 10•10 years ago
|
||
Backing out the other animation inspector changes that landed prior to this made tests angry. Backed out to try to get things green again.
https://hg.mozilla.org/integration/fx-team/rev/f88ae43fbb9c
Assignee | ||
Comment 11•10 years ago
|
||
Relanded part 1 to fx-team, which only contains a really minor html/css styling change to the animation panel and was not related to yesterday's backout.
https://hg.mozilla.org/integration/fx-team/rev/27301bf3af8c
Assignee | ||
Comment 12•10 years ago
|
||
Thanks Victor for the code review.
Landed parts 2 and 3:
remote: https://hg.mozilla.org/integration/fx-team/rev/a87115bb8c7a
remote: https://hg.mozilla.org/integration/fx-team/rev/3add0bfa670f
Assignee | ||
Updated•10 years ago
|
Keywords: leave-open
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/27301bf3af8c
https://hg.mozilla.org/mozilla-central/rev/a87115bb8c7a
https://hg.mozilla.org/mozilla-central/rev/3add0bfa670f
Assignee: nobody → pbrosset
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #8587290 -
Attachment is obsolete: true
Attachment #8619795 -
Flags: review+
Attachment #8619796 -
Flags: review+
Attachment #8619797 -
Flags: review+
Assignee | ||
Comment 15•9 years ago
|
||
Assignee | ||
Comment 16•9 years ago
|
||
Assignee | ||
Comment 17•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•