Wellington Torrejais da Silva Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150312150027

Steps to reproduce:

On try to access ftp:// addresses:
ftp:// not working on E10S, black page is displayed but login windows not displayed


Actual results:

On try to access ftp:// addresses:
ftp:// not working on E10S, black page is displayed but login windows not displayed


Expected results:

Normal ftp:// access with browser on E10S

	Tracy Walker [:tracy]
	Comment 1 • 9 years ago

ftp works for me with latest Nightly build on Mac.

Reporter, please try the build from today.  Also, what addons do you have enabled?  If any, please disable them and try ftp again.

	lixxx235
	Comment 2 • 9 years ago

FTP is also working for me, nightly, Mac 10.9.5.

	Wellington Torrejais da Silva Reporter
	Comment 3 • 9 years ago

Only E10S: The problem occurred only over authenticated FTP. For example: ftp://feitep.com.br/.
But working on non E10S mode. My version: 39.0a1 (2015-03-19)Windows 7 and Linux Mint

	Wellington Torrejais da Silva Reporter
	Comment 4 • 9 years ago

** Please test first on E10S ** 
Only work if first login on non-E10S windows.

	Loic
	Comment 5 • 9 years ago

I'm able to reproduce with your STR in your dupe:

ftp://demo.wftpserver.com
    Username: demo-user
    Password: demo-user

Result: no authentication dialog box, blank page.

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 8 • 9 years ago

This turned out to be pretty straightforward. We had to expose nsIAuthPrompt2 through FTPChannelParent. Because we already pass the necessary information around, and the TabParent already implements nsIAuthPromptProvider, I had to change very little code.

My understanding is that Dragana isn't a peer of Necko yet, so I'm asking her for feedback. Bill, since this patch is mostly IPDL/DOM stuff anyway, would you mind reviewing? I'll verify with jduell before checkin to make sure he's cool with this, too.

	Dragana Damjanovic [:dragana]
	Comment 9 • 9 years ago

Comment on attachment 8635023 [details] [diff] [review]
Patch v1

Review of attachment 8635023 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/ftp/FTPChannelParent.cpp
@@ +471,5 @@
> +      return provider->GetAuthPrompt(nsIAuthPromptProvider::PROMPT_NORMAL,
> +                                     uuid,
> +                                     result);
> +    }
> +  }

Do we need to check if it is content process?

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 10 • 9 years ago

(In reply to Dragana Damjanovic [:dragana] from comment #9)
> ::: netwerk/protocol/ftp/FTPChannelParent.cpp
> Do we need to check if it is content process?

We'll only ever create FTPChannelParents (or nsFTPChannels) in the parent process, so we don't have to verify here that we're not in the content process.

	Bill McCloskey [inactive unless it's an emergency] (:billm)
	Comment 11 • 9 years ago

Comment on attachment 8635023 [details] [diff] [review]
Patch v1

Review of attachment 8635023 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/ftp/FTPChannelParent.cpp
@@ +464,5 @@
> +      uuid.Equals(NS_GET_IID(nsISecureBrowserUI))) {
> +    if (mTabParent) {
> +      return mTabParent->QueryInterface(uuid, result);
> +    }
> +  } else if (uuid.Equals(NS_GET_IID(nsIAuthPrompt2))) {

Might as well include nsIAuthPrompt as well?

::: netwerk/protocol/ftp/FTPChannelParent.h
@@ +19,5 @@
>  class nsILoadContext;
>  
>  namespace mozilla {
> +
> +namespace dom{

Need space.

@@ +41,5 @@
>    NS_DECL_NSIPARENTCHANNEL
>    NS_DECL_NSIINTERFACEREQUESTOR
>    NS_DECL_NSICHANNELEVENTSINK
>  
> +  FTPChannelParent(const dom::PBrowserOrId& iframeEmbedding,

aIframeEmbedding (yuck).

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 13 • 9 years ago

Comment on attachment 8636880 [details] [diff] [review]
Make FTP with auth prompts work in e10s. r=billm/dragana

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ba3015b532b

Jason, I understand that Dragana isn't a peer. Do you want to give this a once-over or are you OK with this landing with the reviews on this bug?

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 14 • 9 years ago

Necko peer*

	Pulsebot
	Comment 15 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/dedc277a5abb

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 16 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/dedc277a5abb