Reproducible on: Nightly 39.0a1 (2015-03-18) Affected platforms: Ubuntu 14.04 (x64), Windows 7 (x64), Mac OS X 10.9.5. Preconditions: * browser.readinglist.enabled = true Steps to reproduce: 1. Launch Firefox. 2. Access an in-content page, (e.g.) about:preferences. 3. Check the Location Bar. Expected result: There's no "Add page to Reading List" button displayed in the Location Bar for this type of pages. Actual result: * The "Add page to Reading List" button is displayed in the Location Bar for in-content pages too. * Clicking the button does nothing and has no visual feedback for the end user. * Clicking the button results in the following error getting thrown in the Browser Console: > TypeError: document.getItems is not a function PageMetadata.jsm:125:39

This patch also fixes bug 1144684.

Hi Florian, can you provide a point value.

Comment on attachment 8580252 [details] [diff] [review] Patch Review of attachment 8580252 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser-readinglist.js @@ +279,5 @@ > */ > togglePageByBrowser: Task.async(function* (browser) { > + let uri = browser.currentURI; > + if (uri.spec.startsWith("about:reader?")) > + uri = ReaderParent.parseReaderUrl(uri.spec); check null here

Null check added.

Verified fixed on Nightly 39.0a1 (2015-03-23), using Ubuntu 14.04 (x64), Mac OS X 10.9.5 and Windows 7 (x64), with all the pages listed in about:about. Please note that Reader View is still available across platforms for the about:credits page, which redirects the user to https://www.mozilla.org/credits/. I think that's expected - Florian, what's your take on this?

(In reply to Andrei Vaida, QA [:avaida] from comment #7) > Please note that Reader View is still available across platforms for the > about:credits page, which redirects the user to > https://www.mozilla.org/credits/. I think that's expected - Florian, what's > your take on this? Seems fine to me; thanks for checking! :)

Verified fixed on Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5, with all the pages from about:about.