This is a slight modification to ClassifyLocal, which takes the list of tables mostly from preferences. This interface will let shumway team (or whomever) check specific tables rather than having to create new error codes (like NS_ERROR_PHISHING_URI) and associate them with table names, which is how the current code runs.

Hey Chris and Josh, I hear lots of different things about how you are planning to use the safebrowsing API. This interface will be required if you decide to do anything other than use the tracking protection list to decide which flash ads to render with shumway. I've talked to Francois about this change already. Basically a new interface needs to be added to https://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsIURIClassifier.idl#63 with signature like string classifyLocalWithTables(nsIPrincipal principal, string commaSeparatedListOfTablesToCheck) where the return value is a comma-separated list of tables that match. Then https://bug1134284.bugzilla.mozilla.org/attachment.cgi?id=8568312 can just call the new function instead of ClassifyLocal. Please let me know if you have any questions. Thanks, Monica

ni Josh to make sure he sees it.

SGTM

Comment on attachment 8580925 [details] [diff] [review] Create ClassifyLocalWithTables ( Review of attachment 8580925 [details] [diff] [review]: ----------------------------------------------------------------- https://treeherder.mozilla.org/#/jobs?repo=try&revision=71220a1f2b26

Comment on attachment 8580925 [details] [diff] [review] Create ClassifyLocalWithTables ( Review of attachment 8580925 [details] [diff] [review]: ----------------------------------------------------------------- gcp is probably a better reviewer for this if he has time.

Comment on attachment 8580925 [details] [diff] [review] Create ClassifyLocalWithTables ( Review of attachment 8580925 [details] [diff] [review]: ----------------------------------------------------------------- This looks OK to me but I can't help wondering whether eventually classifyLocalWithTables will really need to be exposed in the API. I don't think you can sanely use it without leaking a lot of stuff out of nsUrlClassifierDBService into other components.

Comment on attachment 8580925 [details] [diff] [review] Create ClassifyLocalWithTables ( Review of attachment 8580925 [details] [diff] [review]: ----------------------------------------------------------------- Gcp has reviewed these, so I don't think you need my review any more.